Fix #31 Uncaught RangeError: Maximum call stack size exceeded in some browsers #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 20, 2013 14:37
…Maximum callstack problems in some browsers.
… window, modefied the conditional statement so it does not end up in an infinite loop
|
@wcoppens Nice, thank you! |
helios-ag
added a commit
that referenced
this pull request
Jul 21, 2013
Fix #31 Uncaught RangeError: Maximum call stack size exceeded in some browsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original way of re-sizing the ELFinder caused in some browsers a infinite loop resulting in a Maximum call stack size exceed.
It is hard to verify what exactly wen't wrong in the original one, also it is hard to prove that this is a better solution. But it fixes the problem i was having with the old way.