connector options override #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well i think its better to enumerate all options in configuration, there is not much left to include. |
|
ok options are now enumerated. To use them in config.yml, convert their names from camelCased to under_scored syntax. |
|
Well done @nicolasmure 👍 |
|
hey thanks 😃 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a PR to allow connector's options override. Here is the full list of available options : https://github.com/Studio-42/elFinder/wiki/Connector-configuration-options
Previously defined options in app/config/config.yml file are not overriden by this setting, only new ones (who weren't configurable before) are given to the connector.
See you 😄