Skip to content
This repository was archived by the owner on Dec 25, 2018. It is now read-only.

returning path when using 'info' command + provided GET query parameters #19

Merged
merged 1 commit into from
Jun 4, 2015
Merged

returning path when using 'info' command + provided GET query parameters #19

merged 1 commit into from
Jun 4, 2015

Conversation

nicolasmure
Copy link
Contributor

This PR adds a 'path' key containg file's path + name to returned array when using 'info' command.
It also allows to set GET query parameters (previously guessed from $_GET), to enable sub requests.

Related to # 128 on the bundle side.

@helios-ag
Copy link
Owner

Well, it looks fine, but as for me, breaking public method signature will require to mark elfinder api as new major version of the library.
P S. Currently i rewrote some parts of the library (removing direct access to global arrays, replacing by Symfony HttpFoundation component), and covering with unit tests, hope will finish first part till the end of the week.

@nicolasmure
Copy link
Contributor Author

Thanks for your consideration,

I understand the need to make a major version tag, if it's OK for you, you can go ahead.
Or you may want to integrate some of these changes into your rewrite?

helios-ag added a commit that referenced this pull request Jun 4, 2015
returning path when using 'info' command + provided GET query parameters
@helios-ag helios-ag merged commit 3706ef9 into helios-ag:master Jun 4, 2015
@nicolasmure
Copy link
Contributor Author

thank you 👍 !

@nicolasmure nicolasmure mentioned this pull request Jun 4, 2015
@nicolasmure nicolasmure deleted the full-path-info branch June 5, 2015 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants