4.x: JPA testing-related improvements #9131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljnelson
added
enhancement
oracle-contributor-agreement
bot
added
the
OCA Verified
… locate persistence.xml resources Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
…ig properties into the persistence unit properties Signed-off-by: Laird Nelson <[email protected]>
ljnelson
force-pushed
the
jpa-pxml-location
branch
from
9bc2cab to
4d28f7f
Compare
…location works Signed-off-by: Laird Nelson <[email protected]>
|
Still needs documentation updates but before I document it I'll see what people have to say. |
tjquinno
reviewed
Aug 19, 2024
Comment on lines
+320
to
+323
| this.enabled = | ||
| Boolean.parseBoolean(ConfigProvider.getConfig() | ||
| .getOptionalValue(this.getClass().getName() + ".enabled", String.class) | ||
| .orElse("false")); |
There was a problem hiding this comment.
Suggested change
| this.enabled = | |
| Boolean.parseBoolean(ConfigProvider.getConfig() | |
| .getOptionalValue(this.getClass().getName() + ".enabled", String.class) | |
| .orElse("false")); | |
| this.enabled = | |
| ConfigProvider.getConfig() | |
| .getOptionalValue(this.getClass().getName() + ".enabled", Boolean.class) | |
| .orElse("false"); |
Perhaps slightly clearer/less wordy.
There was a problem hiding this comment.
Sadly the contract of a MicroProfile Converter is all but undefined, so it's not guaranteed what will happen in the presence of null or empty String values. The contract of Boolean#parseBoolean(boolean), on the other hand, is rigorous.
Comment on lines
+272
to
+275
| this.enabled = | ||
| Boolean.parseBoolean(getConfig() | ||
| .getOptionalValue(this.getClass().getName() + ".enabled", String.class) | ||
| .orElse("true")); |
There was a problem hiding this comment.
Suggested change
| this.enabled = | |
| Boolean.parseBoolean(getConfig() | |
| .getOptionalValue(this.getClass().getName() + ".enabled", String.class) | |
| .orElse("true")); | |
| this.enabled = | |
| getConfig().getOptionalValue(this.getClass().getName() + ".enabled", Boolean.class) | |
| .orElse("true"); |
Similar comment as earlier.
...grations/cdi/jpa-cdi/src/main/java/io/helidon/integrations/cdi/jpa/PersistenceExtension.java
Show resolved
Hide resolved
| Config config = getOrDefault(instance.select(Config.class), namedSelectionQualifiers); | ||
| properties = | ||
| new StackedMap<>(List.of(properties.keySet()::stream, | ||
| () -> stream(config.getPropertyNames()::spliterator, |
There was a problem hiding this comment.
Similar thoughts about getPropertyNames as above.
...grations/cdi/jpa-cdi/src/main/java/io/helidon/integrations/cdi/jpa/PersistenceExtension.java
Show resolved
Hide resolved
tjquinno
approved these changes
Sep 8, 2024
|
I'll follow this up with additional PRs around documentation and testing; thanks for the approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces MicroProfile Config as a dependency of the JPA CDI integration and uses it to blend MicroProfile Config properties with persistence unit properties. It also allows a user to specify an alternate location for a JPA descriptor, which can be useful in unit testing scenarios.
May close and/or address #7552.