4.x: Support for OKE Workload identity in OCI integration for Service registry #8862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to behavior.
Test some javadoc tags are correctly handled
…ype or builder Checkstyle fixes
oracle-contributor-agreement
bot
added
the
OCA Verified
arjav-desai
reviewed
Jun 20, 2024
arjav-desai
reviewed
Jun 20, 2024
...kload/src/main/java/io/helidon/integrations/oci/authentication/okeworkload/package-info.java
Show resolved
Hide resolved
|
a general nitpick: use full name i.e. authentication instead of atn, all over. |
klustria
previously approved these changes
Jun 21, 2024
Verdent
reviewed
Jun 21, 2024
@arjav-desai do you mean in class names, comments, documentation, config or all? Because: I am OK to replace this, but it will be more "chatty" |
* Remove usages of "Strategy" and replace with "Method" * Typo and other review fixes
|
I have resolved all comments. |
Verdent
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds OKE workload authentication details provider
Extracted some authentication details providers to separate modules (resource and instance principal)
Marked as preview feature (production ready, may have some changes) for service registry
A few fixes in Builder and Config metadata (+ test update)
Documentation
Documentation of service registry features is now only in readme files