[4.x] Add shutdown handler to control shutdown sequence in a deterministic … #8684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…way (instead of shutdown hooks in multiple components)
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…way (instead of shutdown hooks in multiple components)
Resolves. #8685
Description
Currently we add shutdown hooks when needed. Shutdown hooks are threads that are started in a non-deterministic order by the JVM when the process is about to exit.
This PR introduces a service
HelidonShutdownHandlerthan can be either provided throughServiceLoader, or registered manually onio.helidon.Mainand that honorsWeight.A single shutdown hook is introduced that invokes all the shutdown handlers in weighted order (higher weight first).
The
Mainalso adds the requiredjava.util.logging"hack" to keep logging active until the VM shuts down (does not work, and did not work in native image). Once the issue is fixed in Java, we can remove this "hack".Replaced existing workaround and shutdown hook in
LoomServerandHelidonContainerImpl.This is a preparation for Helidon Service Registry/Inject.