Updated test to use in-memory logging handler to avoid problems with flushing #5180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flushing data to disk. This PR also fixes a bug in AccessLogFilter where the enable flag was ignored.
|
See #5135 |
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
ljnelson
reviewed
Oct 14, 2022
...cess-log/src/test/java/io/helidon/nima/tests/integration/server/accesslog/AccessLogTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
tomas-langer
requested changes
Oct 14, 2022
...cess-log/src/test/java/io/helidon/nima/tests/integration/server/accesslog/AccessLogTest.java
Outdated
Show resolved
Hide resolved
…hip. Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
ljnelson
approved these changes
Oct 17, 2022
tomas-langer
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated test to use in-memory logging handler to avoid problems with flushing data to disk. This PR also fixes a bug in AccessLogFilter where the enable flag was ignored.