Skip to content

Minor French translation nitpicks #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 25, 2025

Conversation

Lorsoen
Copy link
Contributor

@Lorsoen Lorsoen commented Mar 8, 2025

Minor modifications of the french translation in the UnleashedRecomp files for :

  • Better use of French punctuation
  • Better grammar
  • Better wording

@Lorsoen
Copy link
Contributor Author

Lorsoen commented Mar 8, 2025

Please don't merge this now. I have several things to correct, I'll do it ASAP

@Lorsoen
Copy link
Contributor Author

Lorsoen commented Mar 8, 2025

Should be good for now

@ActualMandM ActualMandM requested a review from LJSTARbird March 8, 2025 18:49
@DeaTh-G DeaTh-G added this to the v1.0.3 milestone Mar 20, 2025
@blueskythlikesclouds blueskythlikesclouds merged commit 1562907 into hedge-dev:main Mar 25, 2025
1 check failed
@GuckicheLorraine
Copy link

GuckicheLorraine commented Apr 7, 2025

@Lorsoen It is "au-delà", not "au delà"...

https://dictionnaire.lerobert.com/definition/au-dela

It seems there is still errors like "Coup Critique" instead of "Coups Critiques" (plural because of the previous word), but it's way better than before, thx !

@Lorsoen
Copy link
Contributor Author

Lorsoen commented Apr 8, 2025

@Lorsoen It is "au-delà", not "au delà"...

Whoops.

"Coup Critique" instead of "Coups Critiques"

Since "Coup" was capitalized for some reason, I thought it was "quoting" the game itself. The game writes it as "Coup critique" in the Werehog phases, so I wrote it like this. Quotations may have clarified this.

@Lorsoen Lorsoen deleted the french_ql branch April 8, 2025 08:14
@GuckicheLorraine
Copy link

@Lorsoen It is "au-delà", not "au delà"...

Whoops.

"Coup Critique" instead of "Coups Critiques"

Since "Coup" was capitalized for some reason, I thought it was "quoting" the game itself. The game writes it as "Coup critique" in the Werehog phases, so I wrote it like this. Quotations may have clarified this.

Oh ok ! Yeah, it makes sense for Coup Critique said like that, my bad !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants