Fix 1st nak retry one frame shorter. #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HiFiPhile <[email protected]>
hathach
approved these changes
Apr 19, 2025
Signed-off-by: HiFiPhile <[email protected]>
|
Yeah it's safer to check if sof is already enabled, I think it can only happen if CPU usage is very high which makes latency in processing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
A small fix following #3072.
When we enable SOF interrupt the 1st time it could be already pending but uncleared, in
hcd_int_handlergintsts = dwc2->gintsts & gintmsk, sincegintmskis unset yetgintstsis also unset, in result SOF flag is not cleared.Cause SOF fire immediately and retry interval shorter, 2nd poll should happen at 63ms instead.