host/dwc2: resume OUT transfer when PING ACKed #3077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HiFiPhile <[email protected]>
# Conflicts: # src/portable/synopsys/dwc2/hcd_dwc2.c
hathach
reviewed
Apr 18, 2025
| channel->hcchar |= HCCHAR_CHENA; | ||
| } | ||
| } else { | ||
| // Device is ready, resume transfer |
There was a problem hiding this comment.
we don't need to use channel_xfer_start() since all meta data is setup, also it will toggle PID (causing data toggle error). Just enabled channel with channel->hcchar |= HCCHAR_CHENA; is good enough.
…byte command - correctly carry out OUT transfer when PING is ack
hathach
approved these changes
Apr 18, 2025
There was a problem hiding this comment.
thank you for your PR. PING is indeed missing, I have
- rename to next_do_ping for clearer meaning
- I found that in case of transfer complete with NYET, we didn't do ping e.g msc out 31 bytes command
- simply use
channel->hcchar |= HCCHAR_CHENA;to continue transfer with existing meta data. Note channel.hctsiz.do_ping is cleared by host controller when interrupt trigger (in my testing with stm32f769), but we clear it anyway since dwc2 has too many variants :)
@HiFiPhile please re-test if this work for you. I tested without hub
|
Thank you, I think it's good on h7rs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Seems the resume is missing.
Before:
After:
