tusb_fifo: split constant address functions #2132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a missed optimization in the compiler, code for constant address handling is being included in all builds. This change splits the code in different functions to avoid that.
|
Hi, sorry for the delay. It's hard to say, I believe you got reduced size as constant address functions are not used in your case, however on stm32 it increases code size of ~250 bytes. |
|
@mndza Please allow maintainer write access to branch. I've splitted const addr functions with macro so no more size increase when they are actually used. |
|
I can't do that, but I can recreate the PR within a personal repository. Is that OK? |
I'll do a PR then since the approach is different. You can test it first: https://github.com/HiFiPhile/tinyusb/tree/fifo_const_split |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Due to a missed optimization in the compiler, code for constant address handling is being included in all builds. This change splits the code in different functions to avoid that.
Additional context
In some
samd11builds there's a difference of ~480 bytes in the final binary size.