-
Notifications
You must be signed in to change notification settings - Fork 211
feat--frontend-overhaul #1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat--frontend-overhaul #1537
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 221 out of 222 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- frontend/app/package.json: Language not supported
Comments suppressed due to low confidence (1)
frontend/app/src/next/components/runs/runs-histogram.tsx:18
- The useQuery hook is used but not imported. Ensure you import useQuery from the appropriate library (e.g., react-query) to avoid runtime errors.
const workflowRunEventsMetricsQuery = useQuery({
wow im not sure if the rewrite is not bad or if copilot is bad.... |
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 220 out of 221 changed files in this pull request and generated no comments.
Files not reviewed (1)
- frontend/app/package.json: Language not supported
Comments suppressed due to low confidence (2)
frontend/app/src/next/components/runs/run-output-card.tsx:77
- Wrap the JSON.parse(error) call in a try/catch block to prevent the component from throwing an exception if the error string is not valid JSON. For example, default to displaying the raw error string if parsing fails.
error ? JSON.stringify(JSON.parse(error), null, 2) : JSON.stringify(output, null, 2)
frontend/app/src/next/components/providers/support-chat.provider.tsx:58
- Check if the script element is still present in the DOM before calling removeChild in the cleanup function to avoid possible errors.
document.body.removeChild(script);
* simple trigger * populated * feat:trigger modal * clear * Update frontend/app/src/next/hooks/use-runs.tsx Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* simple trigger * populated * feat:trigger modal * clear * Update frontend/app/src/next/hooks/use-runs.tsx Co-authored-by: Copilot <[email protected]> * wip activity log * merged logs * wip * wip * search box * fudge sort * wip improved worker sheet * wip * chore: improve error on dispatcher (#1538) * fix: empty billing context (#1553) * fix: empty * precommit * hotfix: priority nil pointer (#1555) * hotfix: priority on schedule workflow (#1556) * hotfix: priority on schedule workflow * fix: build * build * lint * build --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: abelanger5 <[email protected]>
* chore: improve error on dispatcher (#1538) * fix: empty billing context (#1553) * fix: empty * precommit * hotfix: priority nil pointer (#1555) * hotfix: priority on schedule workflow (#1556) * hotfix: priority on schedule workflow * fix: build * Hotfix: Handle EOF Properly (#1557) * fix: handle EOF properly * chore: version * fix: debug logs * fix: rm eof type * hotfix: priority on cron workflow for v0 (#1558) * fix: one more possible null deref (#1560) * Hatchet Python Blog Post (#1526) * feat: initial pass at first parts of blog post * feat: initial mkdocs setup * feat: first pass at embedding mkdocs * fix: config * debug: paths * fix: unwind docs hack * feat: start working on mkdocs theme * fix: paths * feat: wrap up post * fix: proof * fix: doc links * fix: rm docs * fix: lint * fix: lint * fix: typos + tweak * fix: tweaks * fix: typo * fix: cleanup * fix: go signature and docs (#1561) * fix: go signature and docs * Update examples/v1/workflows/concurrency-rr.go Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * feat: toggle doc sheet * docs: concurrency cleanup (#1562) * feat: storage adapter * docs--worker-config-options (#1535) * docs--worker-config-options * Update frontend/docs/pages/home/workers.mdx Co-authored-by: abelanger5 <[email protected]> * Update worker-configuration-options.mdx * lint --------- Co-authored-by: abelanger5 <[email protected]> --------- Co-authored-by: abelanger5 <[email protected]> Co-authored-by: Matt Kaye <[email protected]> Co-authored-by: Copilot <[email protected]>
* feat: simple workflows list page * feat: refactor + add route for individual workflow * feat: start wiring up workflow detail page --------- Co-authored-by: Gabe Ruttner <[email protected]>
]?.primary || 'text-gray-500', | ||
'bg-transparent', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we do this a lot - I think it's more Tailwind-y to use data attribute variants for this sort of thing. It's not blocking or anything, but I think at some point we should do this
Description
A complete rework of the Hatchet frontend UI/UX to support a more consistent, scalable, and navigable developer experience.
Fixes # (issue)
Type of change
Goals
This PR addresses core UX and structural issues that have grown with the platform:
Structural Changes
use-alerter.ts
notification component (top right) -- right now only invitesuse-api-meta.ts
api metadata for capabilities -- bundles cloud and oss callsuse-api-tokens.ts
api token cruduse-billing.ts
cloud only billing stateuse-breadcrumbs.tsx
breadcrumb state for navigationuse-can.ts
permission based on user and tenant stateuse-cloud-feature-flags.ts
cloud feature flagsuse-crons.ts
cron run cruduse-definitions.ts
definition cruduse-docs-sheet.ts
doc sidebar stateuse-filters.tsx
sharable filter stateuse-managed-compute.ts
cloud managed compute stateuse-members.tsx
tenant member state and invite cruduse-mobile.tsx
is mobileuse-pagination.tsx
sharable page stateuse-ratelimits.ts
ratelimit cruduse-run-detail.tsx
detailed view for workflow and task runsuse-runs.tsx
run list and actions for runsuse-schedules.ts
schedules cruduse-support-chat.ts
cloud chat helpersuse-tenant.ts
tenant cruduse-timeline-context.tsx
state for the waterfalluse-user.ts
user cruduse-workers.ts
worker crudcan
package for consistent authorization checksbreadcrumbs
across relevant pages/next
routing namespace for new UI shellCodeBlock
component for docs-like code consistencyloading...
Pages Ready to Rock ✅
As we burn page design and layout ✅ when it is confirmed to be feature complete and responsive
Auth
/next/auth/login
/next/auth/register
/next/auth/verify-email
Onboarding
/next/onboarding/new
/next/onboarding/invites
Runs
/next/runs
/next/runs/:runId
/next/runs/:runId/:taskId
Scheduled
/next/scheduled
Crons
/next/crons
Tasks
/next/tasks
Services
/next/services
/next/services/:serviceName
/next/services/:serviceName/:workerName
Rate Limits
/next/rate-limits
Settings
/next/settings/api-tokens
/next/settings/team
/next/settings/overview
/next/settings/github
/next/settings/resource-limits
/next/settings/alerting
/next/settings/ingestors