private-ddn: update byoc permission #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@savanipoojan78 Thanks for your PR! I've assigned @robertjdominguez to review it. |
Deploying promptql-docs with
|
| Latest commit: |
eeac066
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc15df57.promptql-docs.pages.dev |
| Branch Preview URL: | https://fix-updatebyocpermission.promptql-docs.pages.dev |
arvi3411301
approved these changes
Jul 8, 2025
robertjdominguez
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation for creating a data plane in a Bring Your Own Cloud (BYOC) setup. The changes include enhancements to the CloudFormation template, updates to AWS permissions, and adjustments to GCP configurations, ensuring improved flexibility and clarity for users.
AWS CloudFormation Template Enhancements:
bashtoyamland added a newExternalIdparameter for trust relationships. This parameter allows customization with validation rules for length and allowed characters.sts:ExternalIdin the trust relationship to reference the newly addedExternalIdparameter instead of the hardcoded value.AWS Permissions Updates:
ec2:DescribeVpcEndpoints,rds:DescribeDBInstances,ec2:CreateSecurityGroup, andiam:UpdateAssumeRolePolicy. These changes expand the scope of supported operations. [1] [2] [3]rds.amazonaws.comin the list of trusted service principals and addedrds:*to the allowed actions, enabling support for RDS-related operations.GCP Configuration Adjustments:
sqladmin.googleapis.comandservicenetworking.googleapis.comto the list of enabled APIs for GCP projects.roles/cloudsql.adminIAM role to the service account for managing Cloud SQL resources.Documentation Updates:
ExternalIdparameter with Hasura, emphasizing its importance when customized./16to/16-/19for both AWS and GCP, providing more flexibility in network configurations. [1] [2]