Provide a way to upgrade the msys install coming with ghcup.

[AndreasPK]

I've recently learned that ghcup comes with a msys install, but it does not provide a built in way to upgrade it.

I discovered this through a unrelated bug where a binary from this msys version has managed to make it's way into the ghc build system.

While a bug on it's own, it made me realize that ghcup (and configure via cabal as a result) was using a 5 year old version of bash which can cause issues with newer configure scripts. (As happened for libffi in ghc's case).

Perhaps ghcup could provide some sort of "upgrade msys" command, and record the time of the last update and record that as a sort of version number.

But I understand that a reasonable UI here is challenging given how msys works.

[jasagredo]

Wouldn't ghcup run -m -- pacman -Syuu twice suffice? Not sure if that is the right syntax though

[hasufell]

So.

There's a big design difference between:

• the ghcup bootstrap script (this is doing the msys2 install)
• the ghcup binary (this only knows of msys2 through an env var)

The binary is strictly unix. It doesn't deal with msys2 directly, because there is no clean way to update it. It's a mutable mess.

So the fact that ghcup doesn't really know about the state of msys2 is deliberate. That's up to pacman.

[hasufell]

Note that we already create a desktop url shortcut to the msys documentation:

ghcup-hs/scripts/bootstrap/bootstrap-haskell.ps1

Line 654 in 1fc6ddc

Create-Shortcut -SourceExe 'https://www.msys2.org/docs/package-management' -ArgumentsToSourceExe '' -DestinationPath 'Mingw package management docs.url' -TempPath $GhcupDir

Pointing to https://www.msys2.org/docs/package-management

[AndreasPK]

Note that we already create a desktop url shortcut to the msys documentation:

Funnily enough, my ghcup install predates the change that also adds those shortcuts. So I suppose this already got better over time.

Wouldn't ghcup run -m -- pacman -Syuu twice suffice? Not sure if that is the right syntax though

I've updated it by starting the relevant msys shell and doing the update from there. This is more about user having to:

• Know that ghcup does come with a msys environment
• Need to know how to update it.

I until very recently know the later but didn't actually realize the former!

Perhaps the framing in my issue wasn't quite optimal, as it focused too much on the second point. I think knowing that there is a msys env that is potentially relevant when you use ghc/cabal via ghcup is important but not that obvious if you "just use it".

It's a mutable mess.

Definitely true

---

I think it would be quite reasonable and actionable for ghcup upgrade to inspect the pacman log to check for the last time something was updated and complain once that is a long time ago.

In a similar fashion to how cabal complains about the hackage data being stale if you haven't updated it for a long time.

If a user wants to upgrade ghcup but hasn't updated ghcups msys env in two years, that's probably not intentional.

[hasufell]

In a similar fashion to how cabal complains about the hackage data being stale if you haven't updated it for a long time.

That's quite different. The hackage index is maintained by cabal itself. It knows about where the files are etc.

GHCup and pacman are two different programs that know nothing about each other.

Also see https://www.haskell.org/ghcup/about/#non-goals

Invoking package managers is explicitly against ghcup philosophy. So even if it had a proper API, we'd still not use it.

Doing fuzzy timestamp checks would be a possibility, but it's not very exciting.

[AndreasPK]

I think ghcup not doing the upgrade/invoking pacman itself is fine. I was thinking more along the lines of a warning based on the timestamps in the pacman log. Which I assume you refer to as doing fuzzy timestamp checks.

Something like this on ghc upgrade

It seems you are upgrading ghcup but according to you haven't updated ghcups msys env for 1377 days. If you want to update your mys env you can read more about how to do so here:

I've mostly opened this ticket because figuring out something is broken because the msys env provides a outdated bash doesn't seem like something that's straightforward for most windows users to do. So while I imagine not many people will run into an issue like this, it can be very painful for those that do.

[hasufell]

I think there might be another way. I'm guessing you're mainly opening the msys2 shell (which is bash) via the desktop shortcut. Maybe we could, upon opening said shell, print a message informing the user along the lines of:

To keep your msys2 env and bash shell up to date, run 'pacman -Syuu'.

This also has a higher chance of crossing the users eyes than a message that's only visible on ghcup upgrade.

[hasufell]

It seems this would work:

C:\ghcup\msys64\msys2_shell.cmd -mingw64 -c 'echo && echo To keep your msys2 env and bash shell up to date, run: pacman -Syuu && bash -l'

[jasagredo]

You might need to run it twice: one for the core runtime, another for the installed packages.

[hasufell]

@jasagredo I'm really lazy right now... can you suggest a concrete wording?

[jasagredo]

Well you can't do it in one go. The first time you invoke it, it will upgrade the runtime and close all MSYS2 running processes included the current terminal. Then the second time it will update the packages.

Probably it would suffice to say

To keep your msys2 env and bash shell up to date, run pacman -Syuu (twice if it updated the msys2-runtime) and restart your shell.

Although that is not exactly correct because it exits if it updates bash, mintty, msys2-runtime and some others maybe that I don't remeber.

[hasufell]

Well, we kinda do this shidderadatsch in the boostrap scripts already... so why not create another desktop item "Update your crap"?

ghcup-hs/scripts/bootstrap/bootstrap-haskell.ps1

Lines 559 to 568 in 87ff2a9

	Print-Msg -msg 'Processing MSYS2 bash for first time use...'
	Exec "$Bash" '-lc' 'exit'
	Exec "$env:windir\system32\taskkill.exe" /F /FI "MODULES eq msys-2.0.dll"
	Print-Msg -msg 'Upgrading full system...'
	Exec "$Bash" '-lc' 'pacman --noconfirm -Syuu'
	Print-Msg -msg 'Upgrading full system twice...'
	Exec "$Bash" '-lc' 'pacman --noconfirm -Syuu'

[hasufell]

I think I'll just go with

To keep your msys2 env and bash shell up to date, run pacman -Syuu (possibly twice) and restart your shell.

[jasagredo]

Seems like it would work:

PS C:\Users\Javier> & "C:/msys64/usr/bin/bash" '-lc' 'pacman --noconfirm -Syuu'
:: Synchronizing package databases...
 clangarm64 is up to date
 mingw32 is up to date
 mingw64                                       457.9 KiB   405 KiB/s 00:01 [#########################################] 100%
 ucrt64 is up to date
 clang64 is up to date
 msys is up to date
:: Starting core system upgrade...
warning: terminate other MSYS2 programs before proceeding
resolving dependencies...
looking for conflicting packages...

Packages (1) msys2-runtime-3.6.1-4

Total Download Size:   1.84 MiB
Total Installed Size:  6.34 MiB
Net Upgrade Size:      0.00 MiB

:: Proceed with installation? [Y/n]
:: Retrieving packages...
 msys2-runtime-3.6.1-4-x86_64                 1884.8 KiB  5.16 MiB/s 00:00 [#########################################] 100%
(1/1) checking keys in keyring                                             [#########################################] 100%
(1/1) checking package integrity                                           [#########################################] 100%
(1/1) loading package files                                                [#########################################] 100%
(1/1) checking for file conflicts                                          [#########################################] 100%
(1/1) checking available disk space                                        [#########################################] 100%
:: Processing package changes...
(1/1) upgrading msys2-runtime                                              [#########################################] 100%
:: To complete this update all MSYS2 processes including this terminal will be closed. Confirm to proceed [Y/n]
SUCCESS: The process with PID 65284 has been terminated.
SUCCESS: The process with PID 32264 has been terminated.
SUCCESS: The process with PID 101316 has been terminated.
SUCCESS: The process with PID 81208 has been terminated.
PS C:\Users\Javier> & "C:/msys64/usr/bin/bash" '-lc' 'pacman --noconfirm -Syuu'
:: Synchronizing package databases...
 clangarm64 is up to date
 mingw32 is up to date
 mingw64 is up to date
 ucrt64 is up to date
 clang64 is up to date
 msys is up to date
:: Starting core system upgrade...
 there is nothing to do
:: Starting full system upgrade...
resolving dependencies...
looking for conflicting packages...

Packages (4) libgpg-error-1.54-1  mingw-w64-clang-x86_64-gettext-runtime-0.24-2  perl-5.38.4-2  which-2.23-4

Total Download Size:    7.35 MiB
Total Installed Size:  46.72 MiB
Net Upgrade Size:       0.01 MiB

:: Proceed with installation? [Y/n]
...
:: Running post-transaction hooks...
(1/2) Updating the info directory file...
(2/2) Updating the info directory file...