Skip to content

testsuite: Pass pkgdb of store used for intree Cabal #9968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

sheaf
Copy link
Collaborator

@sheaf sheaf commented May 3, 2024

Template B: This PR does not modify behaviour or interface of Cabal or cabal-install – it is purely a change in the testsuite.

This PR modifies cabal-testsuite to allow passing the path to the "store" package database. This allows the test suite to handle building packages with a custom setup that depends on other packages (which get installed into the store).

Checklist:

  • Patch conforms to the coding conventions.
  • Add a test that requires this functionality.

@alt-romes
Copy link
Collaborator

This simple but relevant test suite change is ready to be reviewed.

In upcoming #9871, this change is tested by BuildToolPaths because process will be installed in the store when building the in-tree libraries and needed for the test to pass.

@alt-romes alt-romes requested review from mpickering and jasagredo May 8, 2024 07:08
@alt-romes alt-romes added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jun 13, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 15, 2024
@mergify mergify bot merged commit fc5893d into haskell:master Jun 15, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: backport after release attention: needs-backport 3.10 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants