-
Notifications
You must be signed in to change notification settings - Fork 714
cabal-install: dynExe+profExe requires prof+dyn #10994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I haven't managed to write a test for this, because the way things currently work, we compute e.g. whether to build a prof+dyn executable in Thus, the underlying issue only manifests if you directly call the I'm not including a changelog entry either as this should be invisible to users. |
e238448
to
44e077a
Compare
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
44e077a
to
32c2283
Compare
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Let me try first to rebase with |
@mergify rebase |
✅ Branch has been successfully rebased |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
same result as I had |
I think we have no choice but to change the merge label to merge_no_rebase. |
And while we ponder that, let me rebase with github, for science. |
Oh dear, I merged instead of rebasing. My bad. |
@mergify rebase |
This commit updates the logic in cabal-install's 'elaborateInstallPlan' function to ensure that we don't try to build a profiled dynamic executable if the compiler doesn't support the profiling dynamic way. This brings the logic in cabal-install in sync with the Cabal 'configureProfiling' function, which sets 'withDynExe' to false if the user wants a profiled executable but prof+dyn is not supported by the compiler.
✅ Branch has been successfully rebased |
Phew, |
In my experience, no matter how you rebase (with the mergify command, with GitHub UI, or locally), the catch is to have the master branch untouched by the time CI finishes after rebasing. If this is the case, the bot will auto-merge. If the master branch has advanced, you're back exactly to the same point where you were before rebasing. |
This commit updates the logic in cabal-install's
elaborateInstallPlan
function to ensure that we don't try to build a profiled dynamic executable if the compiler doesn't support the profiling dynamic way.This brings the logic in cabal-install in sync with the Cabal
configureProfiling
function, which setswithDynExe
to false if the user wants a profiled executable but prof+dyn is not supported by the compiler.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: