Packagespec v0.1.2/master #9995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2020
samsalisbury
force-pushed
the
packagespec-v0.1.2/master
branch
from
0403753 to
a03f213
Compare
samsalisbury
force-pushed
the
packagespec-v0.1.2/master
branch
from
a03f213 to
fa1c3e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent with merging this PR, all internal Vault engineers should update to packagespec v0.1.2 (download binary for Mac or Linux there).
Updates to packagespec v0.1.2. See packagespec changelog (internal only) for details. Notable changes visible in this PR:
packagespec.mkwhich counts as generated code. This file is managed by packagespec.packages-oss.lock/layersare gone. These files are now written on-the-fly as needed, to a temp directory. This means a lot of deletions in this PR, but will result in much smaller diffs in future.packages-oss.yml.circleci/config/@build-release.yml.tplis gone. This template is now owned by packagespec.Makefile: the check for and removal of old husky git hooks is removed in this PR, it has been in place long enough that we can assume that no one still has them installed.Reviewers: The main file to review is the
Makefile(most of which is deletions) andpackagespec.mkwhich contains the migrated code. In the CircleCI config, you will notice that the cache prefixcache002has been rolled back tocache001. This is safe, because all layerIDs and packagespecID checksums are also updated, invalidating all older caches. That cache prefix is now owned by code in packagespec rather than this repository.