Skip to content

[docs] add known issue where static roles get rotated on upgrade #30145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

elliesterner
Copy link
Contributor

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@elliesterner elliesterner requested a review from a team as a code owner April 1, 2025 14:18
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 1, 2025
Copy link

github-actions bot commented Apr 1, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Apr 1, 2025

Build Results:
All builds succeeded! ✅

anwittin
anwittin previously approved these changes Apr 1, 2025
Copy link
Collaborator

@anwittin anwittin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks Ellie!

Copy link
Contributor

@schavis schavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, updating the older release notes (release-notes/1.16.1, release-notes/1.17.0, release-notes/1.18.0) and upgrade pages (upgrade-to-1.16.x, upgrade-to-1.16.x, upgrade-to-1.17.x, upgrade-to-1.18.x) won't correctly update the versioned docs for those releases. You'll need to make those updates under the relevant release branch (release/1.16.x for the 1.16.x updates, release/1.17.x for the 1.17.x updates, and release/1.18.x for the 1.18.x updates).

@elliesterner elliesterner requested a review from schavis April 1, 2025 22:38
@elliesterner
Copy link
Contributor Author

FYI, updating the older release notes (release-notes/1.16.1, release-notes/1.17.0, release-notes/1.18.0) and upgrade pages (upgrade-to-1.16.x, upgrade-to-1.16.x, upgrade-to-1.17.x, upgrade-to-1.18.x) won't correctly update the versioned docs for those releases. You'll need to make those updates under the relevant release branch (release/1.16.x for the 1.16.x updates, release/1.17.x for the 1.17.x updates, and release/1.18.x for the 1.18.x updates).

Thanks @schavis . I plan to backport those once this one get's merged, so I can just grab the one commit.

@elliesterner elliesterner merged commit 0b9ed13 into main Apr 2, 2025
33 of 34 checks passed
@elliesterner elliesterner deleted the docs/known-issue-static-role-rotations branch April 2, 2025 16:40
elliesterner added a commit that referenced this pull request Apr 3, 2025
)

* add known issue where static roles get rotated on upgrade #VAULT-35117)

* Update website/content/partials/known-issues/static-role-premature-rotations.mdx

Co-authored-by: Sarah Chavis <[email protected]>

* Update website/content/partials/known-issues/static-role-premature-rotations.mdx

Co-authored-by: Sarah Chavis <[email protected]>

---------

Co-authored-by: Sarah Chavis <[email protected]>
elliesterner added a commit that referenced this pull request Apr 4, 2025
) (#30172)

* add known issue where static roles get rotated on upgrade #VAULT-35117)

* Update website/content/partials/known-issues/static-role-premature-rotations.mdx



* Update website/content/partials/known-issues/static-role-premature-rotations.mdx



---------

Co-authored-by: Sarah Chavis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.19.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants