Skip to content

[UI] Sass Deprecation Warnings #29910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

[UI] Sass Deprecation Warnings #29910

merged 1 commit into from
Mar 13, 2025

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Mar 12, 2025

Description

When building Vault UI, Sass was outputting a number of deprecation warnings, both from within the codebase as well as from dependencies. This PR fixes the deprecation warnings and silences warnings from dependencies to clean up the build output and update to current sass patterns.

Note that sass-migrator made the majority of the changes. After the migrator run there were a handful of errors where a stylesheet was extending a class like so:

.toolbar-link {
  @extend .button;
}

This no longer works because of extension scope since the selector .button is not in the stylesheet. For these errors, @use was added:

@use '../core/buttons.scss';

.toolbar-link {
  @extend .button;
}

No more deprecation warnings from sass 🎉

image

I didn't notice any styling that was impacted by the updates but it would be good to test by clicking around and keeping an eye out for things that look off.

Screen.Recording.2025-03-12.at.2.06.05.PM.mov

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@zofskeez zofskeez added this to the 1.20.0-rc milestone Mar 12, 2025
@zofskeez zofskeez requested a review from a team as a code owner March 12, 2025 20:09
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 12, 2025
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@emoncuso emoncuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

@@ -1,3 +1,5 @@
@use '../utils/color_variables';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not within scope of this PR, but we should probably convert these over to HDS tokens.

@zofskeez zofskeez merged commit c4dc26b into main Mar 13, 2025
45 checks passed
@zofskeez zofskeez deleted the ui/hackweek/sass-deprecations branch March 13, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants