Skip to content

enos(replication): wait for both clusters to be healthy before enabling replication #28049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ryancragun
Copy link
Collaborator

Description

Fix a race where we might configure replication before getting secondary cluster IP addresses when using shamir seals.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@ryancragun ryancragun requested a review from a team as a code owner August 9, 2024 22:11
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 9, 2024
@ryancragun
Copy link
Collaborator Author

I verified this locally with 8x replication scenarios using shamir seals and didn't see the race behavior.

Copy link

github-actions bot commented Aug 9, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Aug 9, 2024

CI Results:
All Go tests succeeded! ✅

@ryancragun ryancragun merged commit bf0e156 into main Aug 9, 2024
111 checks passed
@ryancragun ryancragun deleted the ryan/replication-secondary-cluster-ips branch August 9, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant