chore(lint): make consistent make() calls #2154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arybolovlev
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Thank you again for your great contribution @thevilledev! 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the project does not use
make()consistently. Some calls have bothlengthandcapacityequally defined, some justlength. By defaultcapacityequals tolength(see godoc here) which makes this more of a code quality improvement than a fix.Acceptance tests
No new tests added. Acceptance tests do not succeed on
mainas seen on this previous run but they fail exactly the same on this branch :)Release Note
Release note for CHANGELOG:
References
None
Community Note