Add label support to google_compute_snapshot #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
suggested changes
Oct 11, 2017
| apiSnapshot, err := config.clientCompute.Snapshots.Get(project, d.Id()).Do() | ||
| if err != nil { | ||
| return fmt.Errorf("Eror when reading snapshot for label update: %s", err) | ||
| } |
There was a problem hiding this comment.
- Call
d.Set("label_fingerprint", apiSnapshot.LabelFingerprint)here - Extract line 141-153 into a private method call
updateSnapshotLabelor something along those lines. - Reuse the
updateSnapshotLabelfor the create and update method.
There was a problem hiding this comment.
- I don't know if it makes sense to set the fingerprint here, as this fingerprint is immediately out of date once the following set occurs. A read will occur later that puts the correct fingerprint value.
- Done.
- Done.
rosbo
approved these changes
Oct 13, 2017
google/resource_compute_snapshot.go
Outdated
| return fmt.Errorf("Eror when reading snapshot for label update: %s", err) | ||
| } | ||
|
|
||
| // HERE |
There was a problem hiding this comment.
Not sure why there is this HERE comment
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
* Add label support to google_compute_snapshot * Refactor operation polling code to use client directly
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
* Add label support to google_compute_snapshot * Refactor operation polling code to use client directly
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
<!-- This change is generated by MagicModules. --> /cc @chrisst
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add labels for some resource in #17.