Skip to content

Use the new labels model on GKE node pool resource_labels #21058

Open
@rileykarson

Description

@rileykarson

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

GKE introduced a new server-managed label several days ago in the node_config.resource_labels field (discussed in #15848 (comment), although the original issue was related but separate).

We'd originally only applied the mixed-management labels model to resource-level [GCP] labels fields, but the addition of server-mannaged labels to this field means we'll need to apply it there too.

Keep in mind that this appears in 3 places; google_container_cluster's default node pool node_config; google_container_cluster's node_pool.node_config; google_container_node_pool's node_config. Editing node_config.go should mostly work for all 3, +- some CustomizeDiff changes.

New or Affected Resource(s)

  • google_container_cluster
  • google_container_node_pool

Potential Terraform Configuration

References

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions