azurerm_data_factory_linked_services rename properties
#29902
+255
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreallymatt
requested changes
Jul 7, 2025
| Optional: true, | ||
| Computed: true, | ||
| ConflictsWith: []string{"sas_token_linked_key_vault_key"}, | ||
| Deprecated: "`security.enable_backend_ssl30` has been deprecated in favour of the `security.backend_ssl30_enabled` property and will be removed in v5.0 of the AzureRM Provider", |
There was a problem hiding this comment.
This will need a deprecation message matching the property
| if err := d.Set("key_vault_sas_token", flattenAzureKeyVaultSecretReference(keyVaultPassword)); err != nil { | ||
| return fmt.Errorf("Error setting `key_vault_sas_token`: %+v", err) | ||
| if err := d.Set("sas_token_linked_key_vault_key", flattenAzureKeyVaultSecretReference(keyVaultPassword)); err != nil { | ||
| return fmt.Errorf("setting `key_vault_sas_token`: %+v", err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("setting `key_vault_sas_token`: %+v", err) | |
| return fmt.Errorf("setting `sas_token_linked_key_vault_key`: %+v", err) |
Comment on lines
+443
to
+444
|
|
||
|
|
There was a problem hiding this comment.
Not sure why these are added?
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ConflictsWith: []string{"msi_workspace_id"}, |
There was a problem hiding this comment.
Suggested change
| ConflictsWith: []string{"msi_workspace_id"}, |
| Optional: true, | ||
| Computed: true, | ||
| ValidateFunc: workspaces.ValidateWorkspaceID, | ||
| ConflictsWith: []string{"msi_work_space_resource_id"}, |
There was a problem hiding this comment.
Nit: this is redundant since we already have ExactlyOneOf which includes msi_work_space_resource_id and msi_workspace_id
Suggested change
| ConflictsWith: []string{"msi_work_space_resource_id"}, |
Comment on lines
+382
to
+383
|
|
||
|
|
There was a problem hiding this comment.
Not sure why these are added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
Rename properties:
key_vault_sas_token→sas_token_linked_key_vault_keymsi_work_space_resource_id→msi_workspace_idPR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_data_factory_linked_servicesrename properties [azurerm_data_factory_linked_servicesrename properties #29902]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.