azurerm_oracle_autonomous_database - Add support for allowed_ips

[mihretkidane-OCI]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

• modified
  autonomouse_database_resource : added whitelisted_ips to allow users to create autonomous database with public access

• Newly added
  autonomous_database_generate_wallet_resource.go
  autonomous_database_generate_wallet_resource_test.go

Added a new resource and test case to allow customers to generate wallet for autonomous database.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #29672

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[jackofallops]

Thanks @mihretkidane-OCI - Looking much better now the API portion is broken out. There's a handful of items to take a look at if you could, then I think we should be good to go. Once the tests are updated, are you able to post local tests results as a comment since we're currently unable to run them?

[mihretkidane-OCI]

Test results:

[jackofallops]

HI @mihretkidane-OCI - Thanks for the changes, looks like just a couple more items and I think this will be good to go.

[mihretkidane-OCI]

@jackofallops please help review

[jackofallops]

Thanks for the changes @mihretkidane-OCI - with the test results provided this LGTM 👍

outdated