scheduler: mark arn attribute of dead_letter_config as required

[kadrach]

Description

The Arn property of the DeadLetterConfig object is required, even though the documentation indicates otherwise, have confirmed this with the service team.

Relations

Closes #30306 as an empty DeadLetterConfig object will fail schema validation.

References

https://docs.aws.amazon.com/scheduler/latest/APIReference/API_DeadLetterConfig.html

Output from Acceptance Testing

% make testacc TESTS=TestAccSchedulerSchedule PKG=scheduler                                                                                                               ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/scheduler/... -v -count 1 -parallel 20 -run='TestAccSchedulerSchedule'  -timeout 180m
=== RUN   TestAccSchedulerScheduleGroup_basic
=== PAUSE TestAccSchedulerScheduleGroup_basic
=== RUN   TestAccSchedulerScheduleGroup_disappears
=== PAUSE TestAccSchedulerScheduleGroup_disappears
=== RUN   TestAccSchedulerScheduleGroup_nameGenerated
=== PAUSE TestAccSchedulerScheduleGroup_nameGenerated
=== RUN   TestAccSchedulerScheduleGroup_namePrefix
=== PAUSE TestAccSchedulerScheduleGroup_namePrefix
=== RUN   TestAccSchedulerScheduleGroup_tags
=== PAUSE TestAccSchedulerScheduleGroup_tags
=== RUN   TestAccSchedulerSchedule_basic
=== PAUSE TestAccSchedulerSchedule_basic
=== RUN   TestAccSchedulerSchedule_disappears
=== PAUSE TestAccSchedulerSchedule_disappears
=== RUN   TestAccSchedulerSchedule_description
=== PAUSE TestAccSchedulerSchedule_description
=== RUN   TestAccSchedulerSchedule_endDate
=== PAUSE TestAccSchedulerSchedule_endDate
=== RUN   TestAccSchedulerSchedule_flexibleTimeWindow
=== PAUSE TestAccSchedulerSchedule_flexibleTimeWindow
=== RUN   TestAccSchedulerSchedule_groupName
=== PAUSE TestAccSchedulerSchedule_groupName
=== RUN   TestAccSchedulerSchedule_kmsKeyARN
=== PAUSE TestAccSchedulerSchedule_kmsKeyARN
=== RUN   TestAccSchedulerSchedule_nameGenerated
=== PAUSE TestAccSchedulerSchedule_nameGenerated
=== RUN   TestAccSchedulerSchedule_namePrefix
=== PAUSE TestAccSchedulerSchedule_namePrefix
=== RUN   TestAccSchedulerSchedule_scheduleExpression
=== PAUSE TestAccSchedulerSchedule_scheduleExpression
=== RUN   TestAccSchedulerSchedule_scheduleExpressionTimezone
=== PAUSE TestAccSchedulerSchedule_scheduleExpressionTimezone
=== RUN   TestAccSchedulerSchedule_startDate
=== PAUSE TestAccSchedulerSchedule_startDate
=== RUN   TestAccSchedulerSchedule_state
=== PAUSE TestAccSchedulerSchedule_state
=== RUN   TestAccSchedulerSchedule_targetARN
=== PAUSE TestAccSchedulerSchedule_targetARN
=== RUN   TestAccSchedulerSchedule_targetDeadLetterConfig
=== PAUSE TestAccSchedulerSchedule_targetDeadLetterConfig
=== RUN   TestAccSchedulerSchedule_targetECSParameters
=== PAUSE TestAccSchedulerSchedule_targetECSParameters
=== RUN   TestAccSchedulerSchedule_targetEventBridgeParameters
=== PAUSE TestAccSchedulerSchedule_targetEventBridgeParameters
=== RUN   TestAccSchedulerSchedule_targetInput
=== PAUSE TestAccSchedulerSchedule_targetInput
=== RUN   TestAccSchedulerSchedule_targetKinesisParameters
=== PAUSE TestAccSchedulerSchedule_targetKinesisParameters
=== RUN   TestAccSchedulerSchedule_targetRetryPolicy
=== PAUSE TestAccSchedulerSchedule_targetRetryPolicy
=== RUN   TestAccSchedulerSchedule_targetRoleARN
=== PAUSE TestAccSchedulerSchedule_targetRoleARN
=== RUN   TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== PAUSE TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== RUN   TestAccSchedulerSchedule_targetSQSParameters
=== PAUSE TestAccSchedulerSchedule_targetSQSParameters
=== CONT  TestAccSchedulerScheduleGroup_basic
=== CONT  TestAccSchedulerSchedule_scheduleExpression
=== CONT  TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== CONT  TestAccSchedulerSchedule_targetARN
=== CONT  TestAccSchedulerSchedule_endDate
=== CONT  TestAccSchedulerSchedule_targetEventBridgeParameters
=== CONT  TestAccSchedulerSchedule_namePrefix
=== CONT  TestAccSchedulerSchedule_nameGenerated
=== CONT  TestAccSchedulerSchedule_kmsKeyARN
=== CONT  TestAccSchedulerSchedule_groupName
=== CONT  TestAccSchedulerSchedule_flexibleTimeWindow
=== CONT  TestAccSchedulerScheduleGroup_tags
=== CONT  TestAccSchedulerSchedule_disappears
=== CONT  TestAccSchedulerSchedule_basic
=== CONT  TestAccSchedulerSchedule_targetRetryPolicy
=== CONT  TestAccSchedulerSchedule_targetRoleARN
=== CONT  TestAccSchedulerSchedule_targetKinesisParameters
=== CONT  TestAccSchedulerSchedule_targetECSParameters
=== CONT  TestAccSchedulerSchedule_targetSQSParameters
=== CONT  TestAccSchedulerSchedule_description
--- PASS: TestAccSchedulerScheduleGroup_basic (48.56s)
=== CONT  TestAccSchedulerScheduleGroup_nameGenerated
--- PASS: TestAccSchedulerSchedule_disappears (93.43s)
=== CONT  TestAccSchedulerScheduleGroup_namePrefix
--- PASS: TestAccSchedulerSchedule_nameGenerated (101.23s)
=== CONT  TestAccSchedulerSchedule_targetInput
--- PASS: TestAccSchedulerSchedule_basic (101.31s)
=== CONT  TestAccSchedulerScheduleGroup_disappears
--- PASS: TestAccSchedulerSchedule_namePrefix (101.75s)
=== CONT  TestAccSchedulerSchedule_targetDeadLetterConfig
--- PASS: TestAccSchedulerScheduleGroup_tags (103.36s)
=== CONT  TestAccSchedulerSchedule_startDate
--- PASS: TestAccSchedulerScheduleGroup_nameGenerated (62.89s)
=== CONT  TestAccSchedulerSchedule_state
--- PASS: TestAccSchedulerSchedule_groupName (112.43s)
=== CONT  TestAccSchedulerSchedule_scheduleExpressionTimezone
--- PASS: TestAccSchedulerScheduleGroup_disappears (49.14s)
--- PASS: TestAccSchedulerScheduleGroup_namePrefix (62.91s)
--- PASS: TestAccSchedulerSchedule_targetRoleARN (157.48s)
--- PASS: TestAccSchedulerSchedule_scheduleExpression (157.71s)
--- PASS: TestAccSchedulerSchedule_targetARN (157.75s)
--- PASS: TestAccSchedulerSchedule_endDate (199.88s)
--- PASS: TestAccSchedulerSchedule_description (201.25s)
--- PASS: TestAccSchedulerSchedule_targetSQSParameters (201.61s)
--- PASS: TestAccSchedulerSchedule_flexibleTimeWindow (201.61s)
--- PASS: TestAccSchedulerSchedule_kmsKeyARN (201.69s)
--- PASS: TestAccSchedulerSchedule_targetRetryPolicy (201.99s)
--- PASS: TestAccSchedulerSchedule_targetKinesisParameters (205.21s)
--- PASS: TestAccSchedulerSchedule_targetEventBridgeParameters (205.28s)
--- PASS: TestAccSchedulerSchedule_targetInput (114.01s)
--- PASS: TestAccSchedulerSchedule_targetSageMakerPipelineParameters (219.44s)
--- PASS: TestAccSchedulerSchedule_startDate (134.81s)
--- PASS: TestAccSchedulerSchedule_targetDeadLetterConfig (140.06s)
--- PASS: TestAccSchedulerSchedule_scheduleExpressionTimezone (129.96s)
--- PASS: TestAccSchedulerSchedule_state (131.99s)
--- PASS: TestAccSchedulerSchedule_targetECSParameters (255.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/scheduler  258.275s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @kadrach 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSchedulerSchedule_' PKG=scheduler ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/scheduler/... -v -count 1 -parallel 3  -run=TestAccSchedulerSchedule_ -timeout 180m
=== RUN   TestAccSchedulerSchedule_basic
=== PAUSE TestAccSchedulerSchedule_basic
=== RUN   TestAccSchedulerSchedule_disappears
=== PAUSE TestAccSchedulerSchedule_disappears
=== RUN   TestAccSchedulerSchedule_description
=== PAUSE TestAccSchedulerSchedule_description
=== RUN   TestAccSchedulerSchedule_endDate
=== PAUSE TestAccSchedulerSchedule_endDate
=== RUN   TestAccSchedulerSchedule_flexibleTimeWindow
=== PAUSE TestAccSchedulerSchedule_flexibleTimeWindow
=== RUN   TestAccSchedulerSchedule_groupName
=== PAUSE TestAccSchedulerSchedule_groupName
=== RUN   TestAccSchedulerSchedule_kmsKeyARN
=== PAUSE TestAccSchedulerSchedule_kmsKeyARN
=== RUN   TestAccSchedulerSchedule_nameGenerated
=== PAUSE TestAccSchedulerSchedule_nameGenerated
=== RUN   TestAccSchedulerSchedule_namePrefix
=== PAUSE TestAccSchedulerSchedule_namePrefix
=== RUN   TestAccSchedulerSchedule_scheduleExpression
=== PAUSE TestAccSchedulerSchedule_scheduleExpression
=== RUN   TestAccSchedulerSchedule_scheduleExpressionTimezone
=== PAUSE TestAccSchedulerSchedule_scheduleExpressionTimezone
=== RUN   TestAccSchedulerSchedule_startDate
=== PAUSE TestAccSchedulerSchedule_startDate
=== RUN   TestAccSchedulerSchedule_state
=== PAUSE TestAccSchedulerSchedule_state
=== RUN   TestAccSchedulerSchedule_targetARN
=== PAUSE TestAccSchedulerSchedule_targetARN
=== RUN   TestAccSchedulerSchedule_targetDeadLetterConfig
=== PAUSE TestAccSchedulerSchedule_targetDeadLetterConfig
=== RUN   TestAccSchedulerSchedule_targetECSParameters
=== PAUSE TestAccSchedulerSchedule_targetECSParameters
=== RUN   TestAccSchedulerSchedule_targetEventBridgeParameters
=== PAUSE TestAccSchedulerSchedule_targetEventBridgeParameters
=== RUN   TestAccSchedulerSchedule_targetInput
=== PAUSE TestAccSchedulerSchedule_targetInput
=== RUN   TestAccSchedulerSchedule_targetKinesisParameters
=== PAUSE TestAccSchedulerSchedule_targetKinesisParameters
=== RUN   TestAccSchedulerSchedule_targetRetryPolicy
=== PAUSE TestAccSchedulerSchedule_targetRetryPolicy
=== RUN   TestAccSchedulerSchedule_targetRoleARN
=== PAUSE TestAccSchedulerSchedule_targetRoleARN
=== RUN   TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== PAUSE TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== RUN   TestAccSchedulerSchedule_targetSQSParameters
=== PAUSE TestAccSchedulerSchedule_targetSQSParameters
=== CONT  TestAccSchedulerSchedule_basic
=== CONT  TestAccSchedulerSchedule_state
=== CONT  TestAccSchedulerSchedule_kmsKeyARN
--- PASS: TestAccSchedulerSchedule_basic (56.97s)
=== CONT  TestAccSchedulerSchedule_endDate
--- PASS: TestAccSchedulerSchedule_state (100.39s)
=== CONT  TestAccSchedulerSchedule_groupName
--- PASS: TestAccSchedulerSchedule_kmsKeyARN (101.85s)
=== CONT  TestAccSchedulerSchedule_flexibleTimeWindow
--- PASS: TestAccSchedulerSchedule_endDate (99.48s)
=== CONT  TestAccSchedulerSchedule_scheduleExpression
--- PASS: TestAccSchedulerSchedule_groupName (66.86s)
=== CONT  TestAccSchedulerSchedule_startDate
--- PASS: TestAccSchedulerSchedule_flexibleTimeWindow (95.79s)
=== CONT  TestAccSchedulerSchedule_scheduleExpressionTimezone
--- PASS: TestAccSchedulerSchedule_scheduleExpression (76.53s)
=== CONT  TestAccSchedulerSchedule_targetKinesisParameters
--- PASS: TestAccSchedulerSchedule_startDate (96.50s)
=== CONT  TestAccSchedulerSchedule_targetSQSParameters
--- PASS: TestAccSchedulerSchedule_scheduleExpressionTimezone (98.36s)
=== CONT  TestAccSchedulerSchedule_targetSageMakerPipelineParameters
--- PASS: TestAccSchedulerSchedule_targetKinesisParameters (122.88s)
=== CONT  TestAccSchedulerSchedule_targetRoleARN
--- PASS: TestAccSchedulerSchedule_targetSQSParameters (101.58s)
=== CONT  TestAccSchedulerSchedule_targetRetryPolicy
--- PASS: TestAccSchedulerSchedule_targetRoleARN (76.51s)
=== CONT  TestAccSchedulerSchedule_description
--- PASS: TestAccSchedulerSchedule_targetSageMakerPipelineParameters (143.99s)
=== CONT  TestAccSchedulerSchedule_targetECSParameters
--- PASS: TestAccSchedulerSchedule_targetRetryPolicy (98.60s)
=== CONT  TestAccSchedulerSchedule_targetInput
--- PASS: TestAccSchedulerSchedule_description (97.27s)
=== CONT  TestAccSchedulerSchedule_targetEventBridgeParameters
--- PASS: TestAccSchedulerSchedule_targetInput (76.05s)
=== CONT  TestAccSchedulerSchedule_targetDeadLetterConfig
--- PASS: TestAccSchedulerSchedule_targetECSParameters (149.96s)
=== CONT  TestAccSchedulerSchedule_targetARN
--- PASS: TestAccSchedulerSchedule_targetDeadLetterConfig (102.43s)
=== CONT  TestAccSchedulerSchedule_disappears
--- PASS: TestAccSchedulerSchedule_targetEventBridgeParameters (118.08s)
=== CONT  TestAccSchedulerSchedule_namePrefix
--- PASS: TestAccSchedulerSchedule_targetARN (76.55s)
=== CONT  TestAccSchedulerSchedule_nameGenerated
--- PASS: TestAccSchedulerSchedule_disappears (49.46s)
--- PASS: TestAccSchedulerSchedule_namePrefix (52.16s)
--- PASS: TestAccSchedulerSchedule_nameGenerated (55.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/scheduler	730.425s

[ewbankkit]

@kadrach Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.