Merge pull request #30360 from kadrach/fix/scheduler-schedule-target-deadletterconfig-arn-required

scheduler: mark arn attribute of dead_letter_config as required

Author: ewbankkit

.changelog/30360.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_scheduler_schedule: Mark `arn` property of `dead_letter_config` as a required property
+```

internal/service/scheduler/flex.go

@@ -103,7 +103,7 @@ func expandECSParameters(ctx context.Context, tfMap map[string]interface{}) *typ
 		a.LaunchType = types.LaunchType(v)
 	}
 
-	if v, ok := tfMap["network_configuration"].([]interface{}); ok && len(v) > 0 {
+	if v, ok := tfMap["network_configuration"].([]interface{}); ok && len(v) > 0 && v[0] != nil {
 		a.NetworkConfiguration = expandNetworkConfiguration(v[0].(map[string]interface{}))
 	}
 
@@ -611,39 +611,39 @@ func expandTarget(ctx context.Context, tfMap map[string]interface{}) *types.Targ
 		a.Arn = aws.String(v)
 	}
 
-	if v, ok := tfMap["dead_letter_config"].([]interface{}); ok && len(v) > 0 {
+	if v, ok := tfMap["dead_letter_config"].([]interface{}); ok && len(v) > 0 && v[0] != nil {
 		a.DeadLetterConfig = expandDeadLetterConfig(v[0].(map[string]interface{}))
 	}
 
-	if v, ok := tfMap["ecs_parameters"].([]interface{}); ok && len(v) > 0 {
+	if v, ok := tfMap["ecs_parameters"].([]interface{}); ok && len(v) > 0 && v[0] != nil {
 		a.EcsParameters = expandECSParameters(ctx, v[0].(map[string]interface{}))
 	}
 
-	if v, ok := tfMap["eventbridge_parameters"].([]interface{}); ok && len(v) > 0 {
+	if v, ok := tfMap["eventbridge_parameters"].([]interface{}); ok && len(v) > 0 && v[0] != nil {
 		a.EventBridgeParameters = expandEventBridgeParameters(v[0].(map[string]interface{}))
 	}
 
 	if v, ok := tfMap["input"].(string); ok && v != "" {
 		a.Input = aws.String(v)
 	}
 
-	if v, ok := tfMap["kinesis_parameters"].([]interface{}); ok && len(v) > 0 {
+	if v, ok := tfMap["kinesis_parameters"].([]interface{}); ok && len(v) > 0 && v[0] != nil {
 		a.KinesisParameters = expandKinesisParameters(v[0].(map[string]interface{}))
 	}
 
 	if v, ok := tfMap["role_arn"].(string); ok && v != "" {
 		a.RoleArn = aws.String(v)
 	}
 
-	if v, ok := tfMap["retry_policy"].([]interface{}); ok && len(v) > 0 {
+	if v, ok := tfMap["retry_policy"].([]interface{}); ok && len(v) > 0 && v[0] != nil {
 		a.RetryPolicy = expandRetryPolicy(v[0].(map[string]interface{}))
 	}
 
-	if v, ok := tfMap["sagemaker_pipeline_parameters"].([]interface{}); ok && len(v) > 0 {
+	if v, ok := tfMap["sagemaker_pipeline_parameters"].([]interface{}); ok && len(v) > 0 && v[0] != nil {
 		a.SageMakerPipelineParameters = expandSageMakerPipelineParameters(v[0].(map[string]interface{}))
 	}
 
-	if v, ok := tfMap["sqs_parameters"].([]interface{}); ok && len(v) > 0 {
+	if v, ok := tfMap["sqs_parameters"].([]interface{}); ok && len(v) > 0 && v[0] != nil {
 		a.SqsParameters = expandSQSParameters(v[0].(map[string]interface{}))
 	}
 

internal/service/scheduler/schedule.go

@@ -151,7 +151,7 @@ func resourceSchedule() *schema.Resource {
 								Schema: map[string]*schema.Schema{
 									"arn": {
 										Type:             schema.TypeString,
-										Optional:         true,
+										Required:         true,
 										ValidateDiagFunc: validation.ToDiagFunc(verify.ValidARN),
 									},
 								},

website/docs/r/scheduler_schedule.html.markdown

@@ -107,7 +107,7 @@ The following arguments are optional:
 
 #### dead_letter_config Configuration Block
 
-* `arn` - (Optional) ARN of the SQS queue specified as the destination for the dead-letter queue.
+* `arn` - (Required) ARN of the SQS queue specified as the destination for the dead-letter queue.
 
 #### ecs_parameters Configuration Block