Skip to content

helper/schema: Prevent panic with missing InstanceDiff in ReadDataSource #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021
Merged

helper/schema: Prevent panic with missing InstanceDiff in ReadDataSource #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion helper/schema/grpc_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,11 @@ func (s *GRPCProviderServer) ReadDataSource(ctx context.Context, req *tfprotov5.
return resp, nil
}

diff.RawConfig = configVal
// Not setting RawConfig here is okay, as ResourceData.GetRawConfig()
// will return a NullVal of the schema if there is no InstanceDiff.
if diff != nil {
diff.RawConfig = configVal
}

// now we can get the new complete data source
newInstanceState, diags := res.ReadDataApply(ctx, diff, s.provider.Meta())
Expand Down
Loading