Resource Identity: Add the UpgradeRPC for resource identity #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainkwan
force-pushed
the
rk/resource-identity-upgrade
branch
from
50a8421 to
0dd0c36
Compare
rainkwan
force-pushed
the
rk/resource-identity-upgrade
branch
from
aec197a to
52f903d
Compare
austinvalle
reviewed
May 2, 2025
austinvalle
reviewed
May 6, 2025
austinvalle
reviewed
May 12, 2025
rainkwan
force-pushed
the
rk/resource-identity-upgrade
branch
from
fe840ab to
527c850
Compare
austinvalle
force-pushed
the
rk/resource-identity-upgrade
branch
from
527c850 to
63bcd66
Compare
austinvalle
pushed a commit
that referenced
this pull request
May 15, 2025
* Adding the upgradeRPC for resource identity. Still requires some tests. * Updated tests in server_upgraderesourceidentity_test.go * Updated tests in server_upgraderesourceidentity_test.go * Updated tests in server_upgraderesourceidentity_test.go * Addressed PR commenta * Addressed PR comments round 2 * Reverting the renaming for now * Testing renaming again * Renaming to UpgradeIdentity confirmed to fail corner tests * Renaming just for the resource * Renaming the method and interface just for the resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up PR for #1112
This PR adds the UpgradePRC for Resource Identity to Framework.