fix 1.9.0-beta1 changelog formatting #8941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
requested review from
hanshasselberg,
mikemorris,
a team and
preetapan
and removed request for
mikemorris
|
Is that one entry the only instance that needs to be fixed? Trying to figure out why that would be the case... |
|
Yes. I found this one because Side note: maybe that make target needs to be smarter, also we might want to run it in CI to fail the build if the changelog isn't clean already. |
|
Oh, nothing wrong with the auto-formatter here, just a reference to the original issue that was inadvertently added in the changelog entry in #8842, will push up a fix. |
mikemorris
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's something subtly off with the automagic changelog formatter that causes this.