Move RPC router from Client/Server and into BaseDeps

[mkeeler]

This will allow it to be a shared component which is needed for AutoConfig

[dnephin]

Nice! This looks great. I'm not that familiar with agent/router, but I think this all made sense to me. A few minor suggestions.

[dnephin]

The test failures reproduce locally. I think the test assumptions need to change now that there are multiple coordinates? Or does Coordinate.ListDatacenters need to change?

[mkeeler]

@dnephin Our public docs say those APIs are supposed to be only for WAN.

This endpoint returns the WAN network coordinates for all Consul servers, organized by datacenters.

So I probably should filter out the LAN Area servers from the GetDatacenterMaps in the router.

[dnephin]

Ah, makes sense! If it's a concern of the API, maybe filter it out in the api/rpc endpoints instead of GetDatacenterMaps ?

[dnephin]

Nice! This is great.

I would have expected the filtering for LAN to happen in the api/rpc handler, but I don't know this code very well, so maybe that expectation is wrong. One suggestion for the comment to make it more visible, but not a blocker.

[mkeeler]

@dnephin is there any reason why the BaseDeps changes were not backported?

[dnephin]

Not really. I think it would be ok to backport them. I generally wait to backport larger refactor changes to reduce the risk of regressions in patch releases. I see this is tagged for backport so I can prepare a PR to backport all the necessary changes to avoid conflicts when this one is merged.

[dnephin]

Merging #8573 should allow this PR to be automatically backported. I tried it out locally and it merged clean.

[hashicorp-ci]

🍒✅ Cherry pick of commit f97cc04 onto release/1.8.x succeeded!