ui: Redesign - Instance Detail Proxy Info tab #7745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxcode
force-pushed
the
ui/feature/redesign-instance-detail-proxy-tab
branch
3 times, most recently
from
4bf79a7 to
3c840ea
Compare
johncowen
reviewed
May 1, 2020
kaxcode
force-pushed
the
ui/feature/redesign-instance-detail-proxy-tab
branch
2 times, most recently
from
6e520c4 to
16e5b43
Compare
kaxcode
force-pushed
the
ui/feature/redesign-instance-detail-proxy-tab
branch
from
16e5b43 to
e6b751f
Compare
|
|
kaxcode
force-pushed
the
ui/feature/redesign-instance-detail-proxy-tab
branch
from
e6b751f to
d8f7c3d
Compare
johncowen
reviewed
May 7, 2020
kaxcode
force-pushed
the
ui/feature/redesign-instance-detail-proxy-tab
branch
from
d8f7c3d to
331fe30
Compare
johncowen
reviewed
May 7, 2020
| <li class="port"> | ||
| <CopyButtonFeedback | ||
| @copy={{combinedAddress}} | ||
| @name="Address to the clipboard" |
There was a problem hiding this comment.
Cool, I think its just this that needs making into "Address" otherwise the title will say "Copy Address to the clipboard to the clipboard"
// copy-buttonfeed-back.hbs
(concat 'Copy ' name ' to the clipboard')
tbh I'm not even sure if that gets rendered anywhere, but if we did want to add 'to the clipboard' to the feedback tooltip that appears I'd say we should add that into the component itself, personally I wouldn't change that now tho.
johncowen
approved these changes
May 7, 2020
We noticed that it was about time we dug into the app-view component as the skin of the UI has chnged quite a bit since this component started and it has now become slightly more consistent. The %app-view CSS has not changed much and things needed within it have gradually become more clearer. Apart from some refactoring of CSS here, the biggest change is the addition of a `nav` Slot, which gets placed immediately underneath the title of the page. This contains any main navigation elements for the page.
kaxcode
force-pushed
the
ui/feature/redesign-instance-detail-proxy-tab
branch
from
331fe30 to
8dd005e
Compare
kaxcode
added a commit
that referenced
this pull request
May 11, 2020
* Fix clickFirstAnchor bug * Create Proxy Info Tab for Instance Detail Page * Create tests for ProxyInfo and update other scenarios with Proxy data * ui: Refactors our app-view/%app-view component (#7752) Co-authored-by: John Cowen <[email protected]>
johncowen
added a commit
that referenced
this pull request
May 12, 2020
* Fix clickFirstAnchor bug * Create Proxy Info Tab for Instance Detail Page * Create tests for ProxyInfo and update other scenarios with Proxy data * ui: Refactors our app-view/%app-view component (#7752) Co-authored-by: John Cowen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
co-authored by: @johncowen