Skip to content

.gitignore: cut IDE-specific entries and cleanup #7083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2020
Merged

.gitignore: cut IDE-specific entries and cleanup #7083

merged 2 commits into from
Jan 17, 2020

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Jan 17, 2020

Tiny change, inspired by some of the lines I saw reverted in raft#382

@mkcp mkcp added the type/enhancement Proposed improvement or new feature label Jan 17, 2020
@mkcp mkcp requested a review from a team January 17, 2020 18:49
@mkcp
Copy link
Contributor Author

mkcp commented Jan 17, 2020

No need to push user-specific excludes to project-level -- will set .vscode/* locally. Updated PR to remove IDE-specific entry

mkeeler
mkeeler approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkcp mkcp merged commit 4428010 into hashicorp:master Jan 17, 2020
@mkcp mkcp deleted the update-gitignore branch January 17, 2020 19:06
@mkcp mkcp changed the title .gitignore: add vscode and MacOS-specific files. add a little org .gitignore: cut IDE-specific entries and cleanup Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

Assignees
No one assigned
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkcp @mkeeler