Skip to content

fix: service name has to match statefulset name for DNS to work correctly #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Apr 2, 2024

Description

This pull request changes the following:

  • update service name to match statefulset name for DNS to work correctly

Related Issues

Copy link

github-actions bot commented Apr 2, 2024

Unit Test Results

  26 files    26 suites   52s ⏱️
109 tests 105 ✔️ 4 💤 0
110 runs  106 ✔️ 4 💤 0

Results for commit db8ea6e.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (f86f0ff) to head (db8ea6e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #815   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63           

Impacted file tree graph

Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jeromy-cannon jeromy-cannon marked this pull request as ready for review April 3, 2024 12:14
@jeromy-cannon jeromy-cannon merged commit f0896ed into main Apr 3, 2024
@jeromy-cannon jeromy-cannon deleted the 00096-node-refresh branch April 3, 2024 14:45
swirlds-automation added a commit that referenced this pull request Apr 3, 2024
## [0.24.1](v0.24.0...v0.24.1) (2024-04-03)

### Bug Fixes

* service name has to match statefulset name for DNS to work correctly ([#815](#815)) ([f0896ed](f0896ed))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts[Network]: update service name to match StatefulSet to support Kube DNS
5 participants