Skip to content

Ingress nginx fixes #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 8, 2023
Merged

Ingress nginx fixes #154

merged 5 commits into from
May 8, 2023

Conversation

daurnimator
Copy link
Member

No description provided.

@daurnimator daurnimator force-pushed the ingress-nginx-fixes branch from 912d8ff to 24fc8d0 Compare May 7, 2023 04:12
KellerFuchs
KellerFuchs reviewed May 7, 2023
View reviewed changes
ingress-nginx/controller/rbac.yaml
resources:
- configmaps
- pods
- secrets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this giving ingress-nginx access to all secrets in all namespaces? O_o

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I guess the sops secrets too, trough configmaps ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shrug this is what we already had, I just reorganised it

@KellerFuchs
Copy link
Member

@daurnimator Could you split the last commit into a follow up PR?

I'd be OK merging everything else, but I'd need to look at that last change in more detail.

@daurnimator daurnimator force-pushed the ingress-nginx-fixes branch from 24fc8d0 to 5cc43e1 Compare May 8, 2023 09:33
@daurnimator
Copy link
Member Author

@daurnimator Could you split the last commit into a follow up PR?

done.

@KellerFuchs KellerFuchs merged commit 733852b into hashbang:master May 8, 2023
@KellerFuchs
Copy link
Member

@daurnimator The sync attempt failed:

ConfigMap "tcp-services" is invalid: data["22"]: Invalid value: ""22"": a valid config key must consist of alphanumeric characters, '-', '_' or '.' (e.g. 'key.name', or 'KEY_NAME', or 'key-name', regex used for validation is '[-._a-zA-Z0-9]+'),
[... 2 more screenfuls of errors, maybe cascading from that one?]

@KellerFuchs
Copy link
Member

So, the workaround for kubernetes-sigs/kustomize#3446 broke, and the bug is still open? 😬

@daurnimator daurnimator deleted the ingress-nginx-fixes branch May 9, 2023 03:19
@daurnimator
Copy link
Member Author

So, the workaround for kubernetes-sigs/kustomize#3446 broke, and the bug is still open? grimacing

Apparently so :(

@daurnimator daurnimator mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellerFuchs KellerFuchs KellerFuchs approved these changes

@RyanSquared RyanSquared Awaiting requested review from RyanSquared

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daurnimator @KellerFuchs