Skip to content

style: several styling and small changes #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

adamEfraty
Copy link
Collaborator

I've noticed obviously that the app has a nice structure and is working but noticed a milion different ways where features could be added and changed in order to make the code and the website even faster and prettier. for now I made some small adjustments, would contribute in the future more.

@adamEfraty adamEfraty requested a review from NoamGaash as a code owner June 3, 2024 14:24
@NoamGaash
Copy link
Member

NoamGaash commented Jun 3, 2024

Hi, welcome to Databus! 🥳
It's great to see you here.
Please notice there are few things that could help us speed up the review process:

  1. please run npm run lint to see lint errors
  2. please change the PR title to start with style: prefix. Using "conventional commit" titles help release-please (our bot) to make the changelog
  3. Consider making this branch & PR from the original repo (I gave you permissions) so preview can be automatically generated
  4. Consider providing before & after screenshots in your PR description

Thank you!

@NoamGaash NoamGaash changed the title several styling and small changes style: several styling and small changes Jun 5, 2024
@@ -27,7 +27,7 @@ export default defineConfig({
},
},
server: {
port: 3000,
port: 3001,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's made by mistake (?)

@NoamGaash
Copy link
Member

Hi @Sicnecher do you need any help?
Please reply if this PR is still relevant

@NoamGaash
Copy link
Member

feel free to re-open this pull request

@NoamGaash NoamGaash closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants