Skip to content

added manual link to bustooltip #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
259 changes: 259 additions & 0 deletions public/locales
Original file line number Diff line number Diff line change
@@ -0,0 +1,259 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this file?

"donate_title": "",
"Change Language": "",
"light_mode_tooltip": "",
"dark_mode_tooltip": "",
"website_name": "",
"what_is_website": "",
"what_is_website_paragraph": "",
"planning_information": "",
"performance_information": "",
"discovered_mistake": "",
"discovered_mistake_paragraph": "",
"privacy": "",
"aboutPage": {
"privacyText": "<0></0><1></1>",
"licenseInfo": {
"text": "<0></0><1></1>",
"licenseName": ""
},
"contributors": "",
"contributorsText": "",
"contributorsReadMore": "<0></0>",
"contributions": ""
},
"license": "",
"questions": "",
"funding": "",
"funding_paragraph": "",
"mr_meir": "",
"innovation_authority": "",
"migdal_company": "",
"and_smaller_donors": "",
"version": "",
"loading": "",
"failedToFetchVersion": "",
"reportBug": {
"success": "",
"error": "",
"description": "",
"viewIssue": ""
},
"open_video_about_this_page": "",
"youtube_modal_info_title": "",
"bug_type": "",
"bug_type_message": "",
"bug_type_bug": "",
"bug_type_feature": "",
"bug_title": "",
"bug_title_message": "",
"bug_contact_name": "",
"bug_contact_name_message": "",
"bug_contact_email": "",
"bug_contact_email_message": "",
"bug_description": "",
"bug_description_message": "",
"bug_environment": "",
"bug_environment_message": "",
"bug_expected_behavior": "",
"bug_expected_behavior_message": "",
"bug_actual_behavior": "",
"bug_actual_behavior_message": "",
"bug_reproducibility": "",
"bug_reproducibility_message": "",
"bug_attachments": "",
"bug_attachments_upload_button": "",
"bug_submit": "",
"choose_date": "",
"all_rides_completed": "",
"missing_rides": "",
"choose_start_time": "",
"choose_line": "",
"line_placeholder": "",
"actualRoute": "",
"plannedRoute": "",
"directions": {
"North": "North",
"Northeast": "Northeast",
"East": "East",
"Southeast": "Southeast",
"South": "South",
"Southwest": "Southwest",
"West": "West",
"Northwest": "Northwest"
},
"loading_routes": "",
"line": "",
"lineProfile": {
"agencyName": "",
"notFound": "",
"route": {
"direction_forth": "",
"direction_back": "",
"shortName": "",
"start": "",
"end": "",
"mkt": "",
"direction": "",
"type": "",
"alternative": ""
},
"title": "",
"id": "",
"date": "",
"lineReference": "",
"operatorReference": "",
"ride": {
"journey ": "",
"id": "",
"duration": "",
"scheduled": ""
},
"stop": {
"of": "",
"name": "",
"code": "",
"route": "",
"location": ""
}
},
"from": "",
"destination": "",
"velocity": "",
"kmh": "",
"sample_time": "",
"at_time": "",
"vehicle_ref": "",
"drive_direction": "",
"bearing": "",
"unknown": "unknown",
"coords": "",
"hide_document": "",
"show_document": "",
"view_manual": "",
"open_complaint": "",
"complaint": "",
"first_name": "",
"last_name": "",
"id": "",
"email": "",
"phone": "",
"complaint_type": "",
"description": "",
"close_complaint": "",
"submit_complaint": "",
"minutes": "",
"line_not_found": "",
"choose_operator": "",
"direction_arrow": "",
"halufa_ride": "",
"choose_route": "",
"choose_stop": "",
"timestamp_target": "",
"choose_time": "",
"choose_vehicle": "",
"vehicle_placeholder": "",
"dashboard_page_title": "",
"dashboard_tooltip_content": "",
"dashboard_page_graph_title_hour": "",
"dashboard_page_graph_title_day": "",
"group_by_day_tooltip_content": "",
"group_by_hour_tooltip_content": "",
"dashboard_page_description": "",
"bug_date_alert": "",
"start": "",
"end": "",
"rides_planned": "",
"rides_actual": "",
"worst_lines_page_title": "",
"how_to_donate_title": "",
"how_to_donate_text": "",
"donate_through_jgive": {
"com_title": ""
},
"donation_link": "",
"donate_to_hasadna": "",
"donation_through_bank_title": "",
"donation_through_bank_reccomendation": "",
"bank": "",
"donation_through_bank_details_bank": "",
"branch": "",
"donation_through_bank_details_branch": "",
"account": "",
"donation_through_bank_details_account": "",
"account_name": "",
"donation_through_bank_details_account_name": "",
"donation_through_bank_details_additional_message": "",
"errorPage": {
"title": "",
"text": "",
"text2": ""
},
"time_format": "",
"ride_missing": "",
"ride_as_planned": "",
"ride_duped": "",
"ride_extra": "",
"gaps_page_title": "",
"gaps_page_description": "",
"loading_gaps": "",
"checkbox_only_gaps": "",
"planned_time": "",
"planned_status": "",
"order_by_hour": "",
"order_by_severity": "",
"gaps_patterns_page_title": "",
"gaps_patterns_page_description": "",
"choose_dates": "",
"timeline_page_title": "",
"timeline_page_description": "",
"loading_stops": "",
"loading_hits": "",
"hits_not_found": "",
"homepage": {
"show_button": "",
"welcome": "",
"databus_definition": "",
"website_goal": "",
"open_menu": "",
"copyright": ""
},
"time_based_map_page_description": "",
"time_based_map_page_title": "",
"open_menu_description": "",
"loading_times_tooltip_content": "",
"operator": {
"type": {
"light_rail": "",
"rail": "",
"bus": "",
"cable_car": "",
"subway": "",
"taxi": "",
"flex": ""
},
"statistics": "",
"ref": "",
"founded": "",
"area_title": "",
"type_title": "",
"website": "",
"all_lines": "",
"line": "",
"origin": "",
"destination": "",
"profile": "",
"map": "",
"total": ""
},
"datetime_format": "",
"operator_title": "",
"rides_missing": "",
"singleline_map_page_title": "",
"singlevehicle_map_page_title": "",
"singlevehicle_map_page_description": "",
"from_date": "",
"watch_locations_in_range": "",
"show_x_bus_locations": "",
"from_time_x_to_time_y": ""
}
3 changes: 2 additions & 1 deletion src/locale/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"website_goal": "The purpose of the site is to improve the quality of public transportation in Israel by providing reliable information to journalists, citizens, transportation companies, and government officials in Israel.",
"show_button": "Show",
"copyright": "© The Public Knowledge Workshop",
"open_menu": "Start Exploring"
"open_menu": "Start Exploring",
"manual": "View Manual"
},
"homepage_title": "Home",
"dashboard_page_title": "Public transport operators according to planned trips",
Expand Down
3 changes: 2 additions & 1 deletion src/locale/he.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"website_goal": "מטרת האתר היא לשפר את איכות התחבורה הציבורית בארץ ע\"י מתן מידע אמין לעיתונאים, אזרחים, חברות התחבורה, וגורמי ממשל בישראל.",
"show_button": "הצג",
"copyright": "© הסדנא לידע ציבורי (ע\"ר)",
"open_menu": "תתחיל לחקור"
"open_menu": "תתחיל לחקור",
"manual": "צפה במדריך"
},
"homepage_title": "ראשי",
"dashboard_page_title": "קיום נסיעות",
Expand Down
12 changes: 12 additions & 0 deletions src/pages/components/map-related/MapLayers/BusToolTip.scss
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,16 @@
}
}
}

.manualLink {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to add a new CSS class if you're using the MUI Button.

font-family: "Roboto", "Helvetica", "Arial", sans-serif;
font-weight: 500;
font-size: 0.875rem;
line-height: 1.75;
letter-spacing: 0.02857em;
text-transform: uppercase;
margin-top: 8px;
color: #1976d2;
display: block;
}
}
8 changes: 8 additions & 0 deletions src/pages/components/map-related/MapLayers/BusToolTip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,14 @@ export function BusToolTip({ position, icon, children }: BusToolTipProps) {
{showJson ? t('hide_document') : t('show_document')}
</Button>

<a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use MUI <Button> instead of <a/> to have the same style

<Button
  href="https://www.gov.il/BlobFolder/generalpage/gtfs_general_transit_feed_specifications/he/GTFS_Developer_Information_2024.11.21b.pdf"
  target="_blank"
  rel="noopener noreferrer"
  sx={i18n.language === 'he' ? { paddingLeft: 0 } : { paddingRight: 0 }}>
  {t('homepage.manual')}
</Button>

href="https://www.gov.il/BlobFolder/generalpage/gtfs_general_transit_feed_specifications/he/GTFS_Developer_Information_2024.11.21b.pdf"
target="_blank"
rel="noopener noreferrer"
className="manualLink">
{t('homepage.manual')}
</a>

{/* Open Complaint Button */}
<EasterEgg code="complaint">
<Button
Expand Down
Loading