-
Notifications
You must be signed in to change notification settings - Fork 103
docs: Create Storybook Stories for the Components in the Profile and Operator Page #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Create Storybook Stories for the Components in the Profile and Operator Page #1127
Conversation
Cool! Regarding test stabilization, there are |
is working 🙂 |
…proved readability
…lTip component refactor: update startDate argument in AllLinesChart story to use getPastDate with true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional comments - (feel free to merge as-is if you prefer to)
1 Storybook play() (Work but need to add for each component)const meta = {
...
play: waitForContent,
} satisfies Meta<typeof SomeComponent> 2 Storybook Parameters (It is not used in Applitools)parameters: {
eyes: {
waitBeforeCapture: async function () {
const timeout = 180_000;
const pollInterval = 100;
const start = Date.now();
while (document.querySelector('.ant-skeleton-content')) {
if (Date.now() - start > timeout) {
throw new Error('Timeout waiting for skeleton to disappear');
}
await new Promise((resolve) => setTimeout(resolve, pollInterval));
}
},
},
} 3 Storybook Parameters (Failed "No Image Content")parameters: {
eyes: {
waitBeforeCapture: waitForContent
},
} 4 applitools.config.js (It is not used in Applitools)export default {
storybookConfigDir: '.storybook',
async waitBeforeCapture() {
const timeout = 180_000
const pollInterval = 100
const start = Date.now()
while (document.querySelector('.ant-skeleton-content')) {
if (Date.now() - start > timeout) {
throw new Error('Timeout waiting for skeleton to disappear')
}
await new Promise((resolve) => setTimeout(resolve, pollInterval))
}
},
} |
…meters for centered layout
…unctionality with waitForContent
…nt usage in preview
…canvasElement parameter
…ents-in-the-operator-profile-page
…eview configuration
@NoamGaash |
…ents-in-the-operator-profile-page
… dashboard charts
…ents-in-the-operator-profile-page
…ents-in-the-operator-profile-page
Thanks @AvivAbachi ! |
…Operator Page (#1127) Co-authored-by: Noam Gaash <[email protected]> Co-authored-by: Noam Gaash <[email protected]>
✨ New Storybook
🧩 Updated Components
Skeleton
loader for consistent UI.🛠️ Updated Stories
waitForContent
utility for improved testing.getPastDate
.satisfies<typeof SomeComponent>
tags: ['autodocs']
, set by default on.storybook/main.ts
alphabetical
🏷️ Config
.storybook/*
files.