-
Notifications
You must be signed in to change notification settings - Fork 103
test: optimize tests by adding shared utility functions #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YaelChen
wants to merge
9
commits into
main
Choose a base branch
from
fixTestsToUseUtilsFunc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoamGaash
reviewed
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some ideas -
- You can use
expect.extend
to create custom assertions likeexpect(page).toGetRequest('gtfs_agencies/list')
- I think it could be preferable to separate navigation commands (goto, click and so on) from the assertion commands - maybe it can be something like:
const callAssertion = expect(page).toCall('gtfs_agencies/list')
await page.goto('/')
await page.getByRole('link', { name: 'נסיעות שלא בוצעו', exact: true }).click()
await page.getByLabel('חברה מפעילה').click()
await callAssertion
what do you think?
…pen-bus-map-search into fixTestsToUseUtilsFunc
NoamGaash
approved these changes
May 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! Thanks, and apologies for taking the time with the review 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the previous tests (verify an API call for gtfs_agencies, verify the dateFrom parameter is a recent date) as functions under utils, so there won't be unnecessary code duplication.