Improved video generation , performance and quality #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and fixes across multiple files, focusing on improving error handling, refining video streaming and downloading functionality, and adding utility updates. Below is a summary of the most important changes grouped by theme.
Error Handling Improvements:
stream_video
function to validate file existence, ensure range values are within valid bounds, and handle parsing errors gracefully.download_video
function to check file existence, readability, and determine appropriate media types dynamically, with detailed logging for errors.Video Streaming and Downloading Enhancements:
get_task
function by correcting a variable name (v
tofile
) for generating URI paths.stream_video
to handle partial content requests more robustly by ensuring valid byte ranges and fallback behavior for invalid ranges.Dependency and Configuration Updates:
Query
import inapp/controllers/v1/video.py
to support query parameters in API endpoints.Utility and Code Cleanups:
Query
import from thecreate_task
function.Script Enhancements:
webui.bat
to activate a Python virtual environment if it exists and added optional Hugging Face mirror settings.Improve video Quality and performance:
Manual tests:
Tested only on windows 10 , with python 3.10