Skip to content

Feature/output secrets plugin #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 3, 2024
Merged

Feature/output secrets plugin #35

merged 9 commits into from
Jun 3, 2024

Conversation

Sapa96
Copy link
Contributor

@Sapa96 Sapa96 commented May 22, 2024 •
edited
Loading

Requirement : https://harness.atlassian.net/wiki/spaces/PD/pages/21701525892/Support+for+OutputVariables+as+Secrets+in+CI+Stages

Changes :

  1. Dot Env File Support for exporting output Variables
  2. Secrets export support for plugins
  3. GoDotEnv Package update

Testing:

  1. Tested run step output variables export and secret variables export with FF enabled CI_ENABLE_DOTENV_SUPPORT_DOCKER
  2. Tested with custom plugin which exports both secrets and output variables
  3. Tested run step flow with FF disabled

raghavharness
raghavharness reviewed May 29, 2024
View reviewed changes
@Sapa96 Sapa96 merged commit ee1fa69 into master Jun 3, 2024
@Sapa96 Sapa96 deleted the feature/output_secrets_plugin branch June 4, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavharness raghavharness raghavharness approved these changes

@harshjain12 harshjain12 Awaiting requested review from harshjain12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sapa96 @raghavharness