Update to opentelemetry 0.24

[hardbyte]

Currently not propagating across services (which is working in main branch).

See

• https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-otlp/CHANGELOG.md#v0170
• https://github.com/tokio-rs/tracing-opentelemetry/pull/155/files
• https://github.com/TrueLayer/reqwest-middleware/tree/main/reqwest-tracing

Could be related to this issue - davidB/tracing-opentelemetry-instrumentation-sdk#148
Although I tried setting the tracer level to INFO and TRACE.

[hardbyte]

PR just to solicit help with why the trace propagation no longer works after updating to 0.24.

Not planning to merge until reqwest-middleware is released - TrueLayer/reqwest-middleware#171

[mladedav]

The propagation doesn't work exactly because reqwest-tracing uses different tracing-opentelemetry from the verison you're using. The problem is that tracing-opentelemetry adds information to the spans but reqwest-tracing can't read it because it looks for different OtelData from different version of tracing-opentelemetry which isn't there.

Once reqwest-tracing is updated, propagation should work again. You can verify that with patching the dependency from git.

[hardbyte]

Thank you very much for the pointer @mladedav - really appreciate it. I had used an upstream git revision of reqwest-tracing and middleware but I suspect it the same issue for axum-tracing-opentelemetry via its workspace cargo file, as it specifies opentelemetry and opentelemetry_sdk at version 0.23, and = tracing-opentelemetry at 0.24.

I'll see about updating the versions in axum-tracing-opentelemetry to see if they can all got along.

[hardbyte]

Ok that was it - with a very hacky fork of axum-tracing-opentelemetry everything works again:

[davidB]

You should have only one version of opentelemetry in your dependency's graph, because opentelemetry::global used static variables to store tracer_provider, propagator, ... So several versions imply several contexts, tracers,...
(tips on some of my projects I added a check (as part of the ci) into the dependency graph to enforce the one version of opentelemetry. Sorry I don't have access to the command, currently)

[davidB]

FYI, I release new version of crates at https://github.com/davidB/tracing-opentelemetry-instrumentation-sdk with support of opentelemetry 0.24

[hardbyte]

You should have only one version of opentelemetry in your dependency's graph, because opentelemetry::global used static variables to store tracer_provider, propagator, ... So several versions imply several contexts, tracers,... (tips on some of my projects I added a check (as part of the ci) into the dependency graph to enforce the one version of opentelemetry. Sorry I don't have access to the command, currently)

Yes that's a bit of a trap! I'd managed to find that using cargo tree. Will update this branch to use the new tracing-opentelemetry-instrumentation-sdk now. Thanks!