Fix: Conversion MedicationRequest 30-40 unmapped fields #2066
+1,196
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corne
commented
Jun 27, 2025
| @@ -439,61 +436,4 @@ public void copyDomainResource(org.hl7.fhir.r4.model.DomainResource src, | |||
| .map(Extension30_40::convertExtension) | |||
| .forEach(tgt::addModifierExtension); | |||
| } | |||
|
|
|||
| public static org.hl7.fhir.r4.model.MedicationRequest convertMedicationRequest(org.hl7.fhir.dstu3.model.MedicationRequest src) throws FHIRException { | |||
There was a problem hiding this comment.
Moved to MedicationRequest30_40.java
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
============================================
+ Coverage 12.67% 12.80% +0.12%
- Complexity 35317 35697 +380
============================================
Files 2449 2454 +5
Lines 724249 725730 +1481
Branches 210848 211185 +337
============================================
+ Hits 91800 92928 +1128
+ Misses 600621 600616 -5
- Partials 31828 32186 +358 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Corne
force-pushed
the
MedicationRequestConversion3040
branch
from
91bc846 to
8153274
Compare
dotasek
requested changes
Jul 3, 2025
| for (org.hl7.fhir.r4.model.Identifier t : src.getIdentifier()) | ||
| tgt.addIdentifier(Identifier30_40.convertIdentifier(t)); | ||
| for (org.hl7.fhir.r4.model.Reference t : src.getBasedOn()) tgt.addBasedOn(Reference30_40.convertReference(t)); | ||
| for (org.hl7.fhir.r4.model.CanonicalType t : src.getInstantiatesCanonical()) |
There was a problem hiding this comment.
I do not see instantiatesCanonical added to the test anywhere. The new test is great, and very welcome, but we should check that the logic added in the PR works.
| for (org.hl7.fhir.r4.model.Reference t : src.getBasedOn()) tgt.addBasedOn(Reference30_40.convertReference(t)); | ||
| for (org.hl7.fhir.r4.model.CanonicalType t : src.getInstantiatesCanonical()) | ||
| tgt.getDefinition().add(Reference30_40.convertCanonicalToReference(t)); | ||
| for (org.hl7.fhir.r4.model.Reference t : src.getBasedOn()) |
| if (src.hasGroupIdentifier()) | ||
| tgt.setGroupIdentifier(Identifier30_40.convertIdentifier(src.getGroupIdentifier())); | ||
| if (src.hasStatus()) | ||
| tgt.setStatusElement(convertMedicationRequestStatus(src.getStatusElement())); | ||
| if (src.hasIntent()) | ||
| tgt.setIntentElement(convertMedicationRequestIntent(src.getIntentElement())); | ||
| if (src.hasCategory()) | ||
| tgt.setCategory(CodeableConcept30_40.convertCodeableConcept(src.getCategory().get(0))); |
| @@ -62,17 +76,79 @@ public static org.hl7.fhir.dstu3.model.MedicationRequest convertMedicationReques | |||
| tgt.addDetectedIssue(Reference30_40.convertReference(t)); | |||
| for (org.hl7.fhir.r4.model.Reference t : src.getEventHistory()) | |||
| tgt.addEventHistory(Reference30_40.convertReference(t)); | |||
|
|
|||
There was a problem hiding this comment.
Same issues as above. If there's added R3 -> R4 functionality for a field, it should be included in the test.
|
@dotasek can you have another look at this PR? All your remarks should have been processed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Sorry for auto formatting, best to review with hide whitespace enabled)