[Android] Makes compatible with the firebase.core 11.0.4 lib to use GDPR FirebaseAnalytics.enabled property #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hansemannn
as reported here #23 and here
hansemannn/titanium-firebase-core#19 there is an incompatibility problem between the latest versions of
firebase.core 2.2.0, which uses lib 11.0.4, andfirebase.analytics 2.1.0which uses lib 15.0.0.I also tried to build the
firebase.coremodule using the lib 15.0.0 you used in version 2.1.0 (hansemannn/titanium-firebase-core@e6956ab), but it does not even work, it gives me an error because some libraries are already added...Besides, the
ti.playservicesare still at version 11.0.4.The
resetAnalyticsData()method is available starting from lib 11.6.0, but in order to give the possibility to comply with the GDPR and decide whether or not to collect data, it would be at least useful a version of the module, compatible with lib 11.0.4 , which has theFirebaseAnalytics.enabledproperty