Skip to content

sdist: include the tests #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Dec 5, 2024

Hello, I'm packaging rich-argparse for Debian. It would be nice if the next release included the tests so we can run them both at package build time, and later against the installed package.

Thanks!

Before:

$ python3 -m build 
* Creating venv isolated environment...
* Installing packages in isolated environment... (hatchling>=1.11.0)
* Getting build dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating venv isolated environment...
* Installing packages in isolated environment... (hatchling>=1.11.0)
* Getting build dependencies for wheel...
* Building wheel...
Successfully built rich_argparse-1.6.0.tar.gz and rich_argparse-1.6.0-py3-none-any.whl

$ tar tf dist/rich_argparse-1.6.0.tar.gz 
rich_argparse-1.6.0/rich_argparse/__init__.py
rich_argparse-1.6.0/rich_argparse/__main__.py
rich_argparse-1.6.0/rich_argparse/_common.py
rich_argparse-1.6.0/rich_argparse/_lazy_rich.py
rich_argparse-1.6.0/rich_argparse/optparse.py
rich_argparse-1.6.0/rich_argparse/py.typed
rich_argparse-1.6.0/.gitignore
rich_argparse-1.6.0/LICENSE
rich_argparse-1.6.0/README.md
rich_argparse-1.6.0/pyproject.toml
rich_argparse-1.6.0/PKG-INFO

$ unzip -l dist/rich_argparse-1.6.0-py3-none-any.whl 
Archive:  dist/rich_argparse-1.6.0-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
    25106  2020-02-02 00:00   rich_argparse/__init__.py
     3286  2020-02-02 00:00   rich_argparse/__main__.py
     2542  2020-02-02 00:00   rich_argparse/_common.py
     2151  2020-02-02 00:00   rich_argparse/_lazy_rich.py
    13197  2020-02-02 00:00   rich_argparse/optparse.py
        0  2020-02-02 00:00   rich_argparse/py.typed
    14301  2020-02-02 00:00   rich_argparse-1.6.0.dist-info/METADATA
       87  2020-02-02 00:00   rich_argparse-1.6.0.dist-info/WHEEL
     1067  2020-02-02 00:00   rich_argparse-1.6.0.dist-info/licenses/LICENSE
      817  2020-02-02 00:00   rich_argparse-1.6.0.dist-info/RECORD
---------                     -------
    62554                     10 files

After:

$ python3 -m build 
* Creating venv isolated environment...
* Installing packages in isolated environment... (hatchling>=1.11.0)
* Getting build dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating venv isolated environment...
* Installing packages in isolated environment... (hatchling>=1.11.0)
* Getting build dependencies for wheel...
* Building wheel...
Successfully built rich_argparse-1.6.0.tar.gz and rich_argparse-1.6.0-py3-none-any.whl

$ tar tf dist/rich_argparse-1.6.0.tar.gz 
rich_argparse-1.6.0/CHANGELOG.md
rich_argparse-1.6.0/CONTRIBUTING.md
rich_argparse-1.6.0/requirements-dev.txt
rich_argparse-1.6.0/rich_argparse/__init__.py
rich_argparse-1.6.0/rich_argparse/__main__.py
rich_argparse-1.6.0/rich_argparse/_common.py
rich_argparse-1.6.0/rich_argparse/_lazy_rich.py
rich_argparse-1.6.0/rich_argparse/optparse.py
rich_argparse-1.6.0/rich_argparse/py.typed
rich_argparse-1.6.0/tests/__init__.py
rich_argparse-1.6.0/tests/conftest.py
rich_argparse-1.6.0/tests/requirements.txt
rich_argparse-1.6.0/tests/test_argparse.py
rich_argparse-1.6.0/tests/test_optparse.py
rich_argparse-1.6.0/.gitignore
rich_argparse-1.6.0/LICENSE
rich_argparse-1.6.0/README.md
rich_argparse-1.6.0/pyproject.toml
rich_argparse-1.6.0/PKG-INFO

$ unzip -l dist/rich_argparse-1.6.0-py3-none-any.whl 
Archive:  dist/rich_argparse-1.6.0-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
    25106  2020-02-02 00:00   rich_argparse/__init__.py
     3286  2020-02-02 00:00   rich_argparse/__main__.py
     2542  2020-02-02 00:00   rich_argparse/_common.py
     2151  2020-02-02 00:00   rich_argparse/_lazy_rich.py
    13197  2020-02-02 00:00   rich_argparse/optparse.py
        0  2020-02-02 00:00   rich_argparse/py.typed
    14301  2020-02-02 00:00   rich_argparse-1.6.0.dist-info/METADATA
       87  2020-02-02 00:00   rich_argparse-1.6.0.dist-info/WHEEL
     1067  2020-02-02 00:00   rich_argparse-1.6.0.dist-info/licenses/LICENSE
      817  2020-02-02 00:00   rich_argparse-1.6.0.dist-info/RECORD
---------                     -------
    62554                     10 files

Copy link
Owner

@hamdanal hamdanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you.

@hamdanal hamdanal merged commit a729c13 into hamdanal:main Dec 9, 2024
1 check passed
@mr-c mr-c deleted the sdist_include_tests branch December 11, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants