Feature : Metrics for specific process #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreenBlood
force-pushed
the
feat/metrics_specific_process
branch
from
9fcea3e to
c82a37e
Compare
|
Looks great! Thanks! Sorry for the late reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I've stumbled on your project which does exactly what I needed (so thank you :) ). I needed to monitor other processes aswell, so I've added another function in order to allow to monitor metrics for arbitrary PID (for example, child processes of the current process).
I've modified your base
init_process_observerto be a simple wrapper with current PID around a newregister_metricsfunction.(Also, fixed the docstrings to fix the function doc on doc.rs
Best regards :)
Green.