Skip to content

fix: Adapt combobox unit tests to FluentUI internal change #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: Adapt combobox unit tests to FluentUI internal change #2221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ui/src/combobox.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@ describe('Combobox.tsx', () => {
})

it('Adds new typed option only once to options list', () => {
const { getAllByRole, getByRole, queryAllByTitle, } = render(<XCombobox model={{ ...comboboxProps, value: 'A' }} />)
const { getAllByRole, getByRole, queryAllByText } = render(<XCombobox model={{ ...comboboxProps, value: 'A' }} />)
fireEvent.click(getByRole('presentation', { hidden: true }))
expect(getAllByRole('option')).toHaveLength(3)
expect(queryAllByTitle('D')).toHaveLength(0)
expect(queryAllByText('D')).toHaveLength(0)

userEvent.type(getByRole('combobox'), '{backspace}D{enter}')
fireEvent.click(getByRole('presentation', { hidden: true }))
expect(getAllByRole('option')).toHaveLength(4)
expect(queryAllByTitle('D')).toHaveLength(1)
expect(queryAllByText('D')).toHaveLength(1)
})

describe('Wave args', () => {
Expand All @@ -78,13 +78,13 @@ describe('Combobox.tsx', () => {
})

it('Sets args to manually selected option', () => {
const { getByRole, getByTitle } = render(<XCombobox model={{ ...comboboxProps }} />)
const { getByRole, getByText } = render(<XCombobox model={{ ...comboboxProps }} />)
fireEvent.click(getByRole('presentation', { hidden: true }))
fireEvent.click(getByTitle('A'))
fireEvent.click(getByText('A'))
expect(wave.args[name]).toBe('A')

fireEvent.click(getByRole('presentation', { hidden: true }))
fireEvent.click(getByTitle('B'))
fireEvent.click(getByText('B'))
expect(wave.args[name]).toBe('B')
})

Expand Down Expand Up @@ -206,23 +206,23 @@ describe('Combobox.tsx', () => {
})

it('Adds initial value to options if it\'s not included in "choices" prop', () => {
const { getByTitle, getAllByRole, getByRole } = render(<XCombobox model={{ ...comboboxProps, value: 'Z' }} />)
const { getByText, getAllByRole, getByRole } = render(<XCombobox model={{ ...comboboxProps, value: 'Z' }} />)
expect(wave.args[name]).toEqual('Z')
expect(getByRole('combobox')).toHaveValue('Z')
fireEvent.click(getByRole('presentation', { hidden: true }))
expect(getAllByRole('option')).toHaveLength(4)
expect(getByTitle('Z')).toBeDefined()
expect(getByText('Z')).toBeDefined()
})

it('Adds value to choices when both are updated and value was included in previous choices but not in the new choices', () => {
const { getByRole, getAllByRole, getByTitle, rerender } = render(<XCombobox model={{ ...comboboxProps, value: 'A' }} />)
const { getByRole, getAllByRole, getByText, rerender } = render(<XCombobox model={{ ...comboboxProps, value: 'A' }} />)
expect(getByRole('combobox')).toHaveValue('A')

rerender(<XCombobox model={{ ...comboboxProps, value: 'C', choices: ['A', 'B'] }} />)
expect(getByRole('combobox')).toHaveValue('C')
fireEvent.click(getByRole('presentation', { hidden: true }))
expect(getAllByRole('option')).toHaveLength(3)
expect(getByTitle('C')).toBeDefined()
expect(getByText('C')).toBeDefined()
})

it('Display same value if choices change and value is included in choices', () => {
Expand Down Expand Up @@ -324,12 +324,12 @@ describe('Combobox.tsx', () => {
})

it('Adds initial values to options if they are not already included in options ', () => {
const { getByTitle, getAllByRole, getByRole } = render(<XCombobox model={{ ...comboboxProps, value: 'Z' }} />)
const { getByText, getAllByRole, getByRole } = render(<XCombobox model={{ ...comboboxProps, value: 'Z' }} />)
expect(wave.args[name]).toEqual('Z')
expect(getByRole('combobox')).toHaveValue('Z')
fireEvent.click(getByRole('presentation', { hidden: true }))
expect(getAllByRole('option')).toHaveLength(4)
expect(getByTitle('Z')).toBeDefined()
expect(getByText('Z')).toBeDefined()
})
})
})
Expand Down