-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes exports to ExportSpecifier. #119
Conversation
Adds information about the local name for "export { a as b }" and whether it's an ambient export or not. Breaking change for the parse() API since exports is no longer an array of strings.
I'm wondering if I've fully thought through the "ambient" concept. I guess the point is to try and work out when a local binding is live in that it could change. Perhaps the local binding existing at all is the only thing that affects that though I suppose? In which case any As for the identifier thing with I had a look at the CI issues. The Windows failure was a CI regression, which I've just removed for now. But the other failure seems specific to the PR. While I could get the tests running locally it may be some other kind of CI issue. Will look into it further soon. In the mean time, let me know if the above localName alignment makes sense to you. Thanks again for the work on this! |
Released in 1.0.0. |
* exports[0].n; | ||
* // Returns "asdf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't that be an example of ln
?
so more like
* exports[0].ln;
* // Returns "a"
?
or am I wrong in the assumption that this is the way to get "a"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's definitely a typo, thanks for spotting it!
Thanks for getting this merged so quickly! I just realized that Edit: and |
Yes, you're right on these. I think we should do that, since they are actually assignable as well would you believe it. But that can be a follow-up fix anytime. |
Closes #116.
Adds information about the local name for "export { a as b }" and whether it's an ambient export or not.
Breaking change for the parse() API since exports is no longer an array of strings.