Fix code scanning alert no. 10: Incomplete string escaping or encoding #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/guruh46/vscode-gitlens/security/code-scanning/10
To fix the problem, we need to ensure that backslashes are properly escaped in the input string. This can be achieved by adding an additional
replacecall to escape backslashes before escaping other characters. Specifically, we should replace backslashes with double backslashes before replacing parentheses.The best way to fix the problem without changing existing functionality is to modify the
createMarkdownCommandLinkfunction to include an additionalreplacecall for backslashes. This change should be made in the filesrc/system/commands.tson lines 13-16.Suggested fixes powered by Copilot Autofix. Review carefully before merging.