Model output is not working

[federico-galfione]

Describe the bug
When using a model signal (for example test = model<string>()) and adding its output (testChange), the library throws the error Component testChange is not an output!

Expected behavior
The component should accept the output for model signals (e.g. testChange).

Reproduction
Stackblitz

Environment:

• Library version: [e.g. 10.8.1]
• Angular version: [e.g. 19.0.0]

Additional context
The problem raises cause in the method isOutputSignal the code checks if the value is an object. It works for outputs, but in the case of a model the property is actually a getter function.
I made some tests and changing the condition to:

private isOutputSignal(value: unknown): boolean {
    return (
      (typeof value === 'function' || typeof value === 'object') &&
      value !== null &&
      typeof (value as any)['subscribe'] === 'function'
    );
  }

makes it work.
I can open a PR, but let me know if you have any feedback regarding the issue, cause I'm not sure if I'm missing something here.

Thank you for the amazing work!

[gund]

Thanks for reporting this issue, you are correct the output in this case seems to the a function instead of the object.
I think it's best to replace current checks to have generic check for a non nullable value instead of object specifically, so instead of typeof value === 'object' && value !== null we should use value != null which will allow for any type as long as it's not falsy and has subscribe method on it.
If you like you can create a PR for this and since the lib is on the old angular version we do not need test cases for this as they are synthetic anyway.

[gund]

Btw I just found that angular has isSignal function from @angular/core which we can use instead of doing custom checks.
Lets switch to it instead and update unit tests to mock this function so they work as expected.
Let me know if you want to create a PR for this or if I should take over.

[federico-galfione]

I'm gonna take a look tomorrow, but I think we need to do some custom checks anyway (like the one you already did).
isSignal works for models since they are actual signals, but for outputs it returns false since they are objects of type OutputRef.
Also if we use only isSignal if someone puts an input signal in ndcDynamicOutputs it will pass the check and we'll have a runtime error on outputToObservable

[gund]

I see, well then lets use a simplified check that I proposed earlier with the .subscribe() method check which should satisfy our case, if it's signal-like (has subscribe method on it) then we assume it's an output.

[github-actions]

🎉 This issue has been resolved in version 10.8.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀